0.9.9: live snapshot details, install-only log rules, faster switches #122
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!122
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-103"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Builds on 0.9.8 (PR #117); merge that first.
The build with warnings as errors and the format check pass locally. - Every pack a capture's add writes gets a .keep, and each routine repack first keeps any pack of at least 128 MiB holding at most 1024 objects, so geometric repacking can no longer roll up and rewrite the big streamed archives (it did on the second routine repack after a big first snapshot, about 85 GiB for Cyberpunk). Free up space removes SavePoint's keeps first, so unreachable big files still go. Closes #120.
build/msys2-sources.ps1 reads etc/package-versions.txt from the extracted bundle, finds each package's source archive the way build-extra/get-sources.sh does (Git for Windows pacman-repo release for the exact version first, then repo.msys2.org as .src.tar.zst then .src.tar.gz), downloads it to a cache folder, hashes it and writes the list in the existing format. Packages built from another package's source (libatomic from gcc, curl-winssl from curl) are looked up under that source. Packages without an archive are reported with the addresses tried and nothing is written. The network is two injectable scriptblocks, so the tests never touch it. Each archive's .sig is verified with gpg in a private home holding only the keys pinned in build/keys (MSYS2 development key for repo.msys2.org, Git for Windows release key for the pacman-repo releases). A bad, missing or foreign signature stops the run and removes what the run downloaded. Observed reds (Msys2SourcesScriptTests): all 29 first tests failed with "build/msys2-sources.ps1 does not exist."; the 13 signature tests failed on the pwsh exit-code assertion ("term not recognized") and on Assert.Contains "Sub-string not found" for the Find-PackageSources cases; the gitk case failed on Assert.StartsWith (it was looked up as mingw-w64-gitk, not mingw-w64-git). Mutation checks: deliberate breakages of the script (dedupe, alias table, extension order, tag/version match, text cache, failed-url set, cache reuse, sort orders, missing report, BOM, bundle check, shorter-name fallback, malformed line, BADSIG, primary fingerprint, signature check, pinned host, missing signature) each failed at least one test; all restored.A game's Files to leave out rules name files whose content can differ from the target. The switch aligns their index entries to the target, so they never match on stat and git hashed them in the checkout's own refresh, in the refresh after the switch, and in the verify diff. A 2 GB left-out cache cost three extra full reads per switch. The alignment now marks those entries skip-worktree for both kinds of switch (it did so only for a forced one), which git honors in all three places. The mark is taken off once the verify pass ends, and also when the switch fails or is stopped, so a later save cannot miss the file. The alignment's own refresh stays: it is the one read that tells a file already holding the target's bytes, and gives it a valid stamp so later comparisons do not read it again. Reds observed before the change (LeftOutReadOnceTests): - The_cache_is_marked_skip_worktree_while_the_index_is_refreshed_and_while_the_verify_pass_looks (both modes): Expected "update-index sees S", Actual "update-index sees H". - A_left_out_file_that_already_holds_the_targets_bytes_keeps_a_valid_stamp_in_the_index failed against a --no-refresh variant of the alignment ("size: 0" found), which is why the refresh stays. Tests that passed on first run were mutation-checked: removing the clear after verify fails The_mark_is_gone_when_the_switch_ends...; disabling the clear on failure fails The_mark_is_taken_off_when_the_verify_pass_gives_up; making verify skip every file fails A_file_the_patterns_do_not_name_is_still_checked_and_written_again. Measured on a 4 x 512 MB left-out folder that differs between two snapshots: switch 21.5 s and 23.8 s before, about 15 s after (the refresh and verify diff fell from about 4.7 s to 0.2 s, the checkout's own refresh from about 3.5 s to 0).A forced switch with only alike left-out files marked the real index after the switch note was written; a failing mark left a note for a switch that wrote nothing, and a save then refused with an interrupted switch. The marks now go on before the note, and a failure clears them. A forced switch to a new target after an unfinished one marked an index entry the target lacks (aligned to the unfinished switch's own target), and git refused the merge ("Entry not uptodate. Cannot merge"). Alike entries are now limited to those the target holds. The clear at the end of a switch only runs when the switch marked something. The clear also reads the index header and skips the listing for a version 2 file, which cannot hold a flag. The bundled git (2.56.0.windows.2) writes version 4 here, which can, so on this git the start-of-operation listing still runs; the version tests set the version with update-index --index-version. Reds observed before the change (LeftOutReadOnceTests): - A_failure_to_mark_the_alike_file_leaves_no_note_of_an_unfinished_switch: the note of an unfinished switch was left. - A_forced_switch_to_another_target_after_an_unfinished_one_ignores_entries_the_target_lacks: GitOperationException, git checkout profile-c exited with code 128: Entry 'Cache/p.txt' not uptodate. Cannot merge. - A_switch_that_marks_files_asks_git_once_for_marks_after_it_verified: Expected 1, Actual 2. Mutation checks: removing the marks guard fails the "only at the start" and "once after verified" tests; disabling the version-2 skip fails the version test. The alike-only forced switch test passed on first run and covers the newly reachable branch.The three start buttons sit in a WrapPanel that shrinks to its widest line. A button that wrapped onto a shorter line sat at the panel's left edge, so the group looked off-center at the default window size and at every narrower one. ItemsAlignment="Center" centers each wrapped line inside the panel. Added FirstRunLayoutTests: each line of buttons has equal left and right gaps at 1040, 760, 560 and 420 wide, the narrow window really wraps, and the icon and label are centered in each button (and in How SavePoint works) when the button is wider than its content. Observed red before the fix: Each_line_of_start_buttons_is_centered_in_the_row, all four widths, e.g. "At width 1040 a line has gaps 0 left and 152 right in a row 411 wide" and "At width 420 ... 0 left and 66 right in a row 259 wide". The content-centering test passed on its first run; mutation check: HorizontalContentAlignment="Left" on AddFromLibrariesButton failed it ("AddFromLibrariesButton at width 1040 has content gaps 25 left and 96 right"), then restored.The sidebar's "Add games from your libraries" label wraps onto two lines, and the wrapped lines were left-aligned inside the label's own box. TextAlignment="Center" on both footer labels centers every wrapped line, and the icon-and-label group stays centered in the button. The library layout's shelf buttons hold a single-line label that the button theme already centers. Added SidebarFooterButtonTests: each text line of the sidebar button labels is centered on the label's box, and the icon-and-label group has equal gaps in each button, in the expanded and the compact sidebar. Observed red before the fix: Each_line_of_a_sidebar_button_label_is_centered_under_the_others(width: 1040), "RailLibrariesButton at width 1040: a line of 2 is 1.83 px off the label's center". The group-centering test passed on its first run; mutation check: HorizontalContentAlignment="Left" on RailAddButton failed it ("RailAddButton at width 1040 has gaps 13 left and 103 right"), then restored.