Reconnecting a game to older history skips the saves check for leave-out rules #114
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#114
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When a new game's folders already hold SavePoint history,
GamesApi.ResolveOrphanAsync(reconnect or start fresh) saves the game without the checkGamesApi.Addruns on the default leave-out rules (**/*.log,**/*.dmp,**/*.mdmp). If the saves folder holds files one of those rules matches, the rule is kept and those saves are left out of every snapshot. Run the sameCheckLeaveOutAsyncstep on that path and drop any default rule it blocks, with the same editor message.Checked on the branch that adds the default rules: both resolutions (reconnect and start fresh) already save through the same path as Add, which drops a default rule that would leave out saves, and the editor shows the same message. The gap does not exist. Branch issue-114-reconnect-saves-check adds tests that pin this for both resolutions and for the case where nothing matches. This issue closes when those tests merge.