Reconnecting a game to older history skips the saves check for leave-out rules #114

Closed
opened 2026-10-25 00:42:07 -05:00 by ethan-hann · 1 comment
Owner

When a new game's folders already hold SavePoint history, GamesApi.ResolveOrphanAsync (reconnect or start fresh) saves the game without the check GamesApi.Add runs on the default leave-out rules (**/*.log, **/*.dmp, **/*.mdmp). If the saves folder holds files one of those rules matches, the rule is kept and those saves are left out of every snapshot. Run the same CheckLeaveOutAsync step on that path and drop any default rule it blocks, with the same editor message.

When a new game's folders already hold SavePoint history, `GamesApi.ResolveOrphanAsync` (reconnect or start fresh) saves the game without the check `GamesApi.Add` runs on the default leave-out rules (`**/*.log`, `**/*.dmp`, `**/*.mdmp`). If the saves folder holds files one of those rules matches, the rule is kept and those saves are left out of every snapshot. Run the same `CheckLeaveOutAsync` step on that path and drop any default rule it blocks, with the same editor message.
ethan-hann added this to the 1.0 milestone 2026-10-25 00:42:07 -05:00
Author
Owner

Checked on the branch that adds the default rules: both resolutions (reconnect and start fresh) already save through the same path as Add, which drops a default rule that would leave out saves, and the editor shows the same message. The gap does not exist. Branch issue-114-reconnect-saves-check adds tests that pin this for both resolutions and for the case where nothing matches. This issue closes when those tests merge.

Checked on the branch that adds the default rules: both resolutions (reconnect and start fresh) already save through the same path as Add, which drops a default rule that would leave out saves, and the editor shows the same message. The gap does not exist. Branch issue-114-reconnect-saves-check adds tests that pin this for both resolutions and for the case where nothing matches. This issue closes when those tests merge.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#114
No description provided.