A switch reads left-out files twice when they differ from the target #110
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#110
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Since the index refresh after a switch (#104, D41.11), files matched by a game's Files to leave out rules whose content differs from the target are hashed by the refresh (their aligned index entries never match on stat) and again by the verify pass's
git diff, which only skips them after git has read them. A game that leaves out a large cache would pay one extra full read of it per switch. Limiting the verify diff with--pathspec-from-filedoes not work (git diffrefuses it, exit 129); doing it properly means passing paths in batches on the command line or excluding the left-out paths with pathspec magic. Measure on a game with a big left-out folder before changing anything.