Faster switches on big games, real game versions, opaque Free up space token, small fixes #112
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!112
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-101"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
++Game+release.1.4.7-CL-196638now shows 1.4.7) or an engine version (Unity, Unreal fixed numbers, placeholders). Checked against 252 game programs; D54 records the rule.Each change was reviewed (Opus for #104); docs updated.
Closes #104
Closes #103
Closes #14
Closes #106
Closes #107
Closes #101
The detected version for Unreal games read like "++Game+release.1.4.7-CL-196638", and Unity players and engine-stamped executables reported the engine's numbers. Read from real version resources of installed games: - An Unreal build id ("++" prefix or "-CL-<n>") now yields only a dotted game number inside it (1.4.7, 0.3.7, 1.11.0.0), or nothing. - A Unity player ("Unity Version" key or a "2022.3.62f2 (hash)" product version) reports nothing. - The fixed numeric version is used only when the file has no version string at all and is not an Epic Games or UnrealEngine executable; with strings present it is the engine's number (Grounded 4.27.2, Hogwarts Legacy 4.27.2). - The 1.0 placeholder and strings with no digit are not versions. Observed reds (assertion failures, before the change): - An_unreal_build_id_that_carries_the_game_version_shows_just_that_version: Expected "1.4.7", Actual "++Game+release.1.4.7-CL-196638" (also 0.3.7, 1.11.0.0) - An_unreal_build_id_gives_way_to_a_real_file_version_string: Expected "2.3.4", Actual "++UE4+Release-4.26-CL-0" - An_unreal_build_id_without_a_game_version_...: Assert.Null failed, Actual "Subnautica2-CL-131439" and "Dev-CL-0" - A_version_string_with_no_digit_is_no_version: Actual "^VersionString^" - The_fixed_version_of_an_engine_vendors_executable_...: Actual "4.20.3" Tests that passed on their first run (Unity, placeholder, rejected-string fixed fallback, engine-named product) were mutation checked: disabling the Unity and engine-name early return and the fixed-version guard failed 11 tests.The test reads the marker before each git starts, so it sees the stamp of the git before. On Linux a git that has already exited when its start time is read is reaped at once and cannot be stamped, so it is not noted. That is safe, since nothing is left to wait for, but the test required a stamp at both reads and failed on the Linux gate (Assert.NotNull: Nullable<ProcessStamp> has no value, line 45). The test now requires at least one of the two reads to name a git, and different gits when both do. Mutation check: with ReclaimStep's Started callback emptied, the test fails ("no git the reclaim started was noted").