A snapshot's details list only a few of the changed files and say nothing while the game folder copies #108
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#108
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
First snapshot of A Plague Tale: Innocence on 0.9.7 (Windows, 44.6 GB, 222 files in the game folder, done in about 6 minutes). The Activity details showed the saves folder's file and its count, then nothing about the game folder for minutes while the bar moved; when the job finished they listed only four game files (APlagueTaleInnocence_x64.exe, RTC/LV12_INVASION.DPC, RTC/LV12_TRANSITION.DPC, zlibd.dll) before "222 files were new, changed or removed in the game folder." The count comes from git's full list, so the names were read but most never became detail lines: progress reports are throttled to about twenty a second and the file list arrives from git in a burst at the end (D50), so most names are dropped with the skipped reports. Since #91 a path is also added only once.
Make the details list every changed file once (newest 200 kept, as the recent lines already are) independent of progress throttling, and while a folder copies with no names yet, say so in plain words (for example the folder and how much of it is done) instead of going quiet. Check switches and Free up space for the same gap.
Approach (discussed 2026-10-24). Streaming git's output to a file instead of a pipe would not help: git buffers its stdout whenever it is not a terminal, so names would reach the file in the same late chunks. Options, in order:
GIT_FLUSH=1in the capture's git environment and check whethergit add -vthen writes each name as it goes (cheap; one setting).--pathspec-from-fileper few hundred files or about 1 GB), so each batch's names arrive when it ends; a few dozen extra git starts on a big game is small next to a multi-minute copy.Separately, every name git does print must become a detail line regardless of progress throttling (the burst at the end is what drops most of them today).