A routine repack still rewrites a capture's big files on a later run #120
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#120
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
D25 and D50 promise that a routine repack never rewrites the big files a capture streams.
git repack --geometric=2sorts packs by object count, and a capture's streamed pack holds only a few objects (about 17 for Cyberpunk), so it is always the lightest and is rolled up the first time two neighbouring packs break the factor of 2. Measured with the bundled git 2.56: one big pack survived routine repacks 1 and 2 and was rewritten on repack 3. In production the routine repack runs at more than 5000 loose objects, so after a big first snapshot the packs hold about 17 and about 5100 objects, and the second routine repack merges everything, copying every big archive (about 85 GiB for Cyberpunk) into a new pack. That takes minutes to tens of minutes in the background, and routine mode checks free space without the store's size, so on a mid-range PC with less free space than the game it can fill the disk.This predates grouped staging (one add for every file over 128 MiB keeps it to one pack per capture, but does not stop the roll-up). A
.keepfile beside the streamed pack kept it through 4 routine repacks in the same experiment. Reclaim (repack -a -d) also skips kept packs, so Free up space must remove the.keepfiles first (or pass--pack-kept-objects) so unreachable big files still go. Decide the rule (for example, mark every pack a capture streams as kept; reclaim drops all keeps and rewrites once), test that a routine repack never rewrites a kept pack across several captures and that Free up space still removes a big file no snapshot reaches, and correct the D50 sentence and the comment at StagingBatches.cs that say the repack leaves the pack in place.ethan-hann referenced this issue2026-10-25 02:36:58 -05:00