0.9.2: gate checks, platform fixes, plainer errors, process-name suggestion #59
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!59
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-092"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Bundles the fixes for the 0.9.2 pre-release. Each issue was built test first on its own branch; the commit messages record the observed reds.
Gate: the App and Core test modules run side by side (#51), and the gate fails on a skipped test its OS's list does not name (#50,
tools/SkipCheck,build/expected-skips/). New tests prove the layout, automation and job-pill audits can fail (#49).Platform: Cmd+C copies job details on macOS (#4). On Linux an exited but unreaped git counts as gone, for both the stamp check and the wait at start (#35).
Snapshots and storage: a folder an update found nothing new in reports Skipped instead of Ok (#22); regression tests for a held file during a first snapshot, which already names the file (#23); the startup screen says when it is finishing an earlier cleanup (#8); a storage move is allowed from the folder "Start with an empty folder" made, marked by a file it writes, while an unmarked empty folder stays refused (#21, BL-004).
Screens: pinned footers, banners and cards lift above the job pill (#9); History scrolls as a whole and keeps three snapshot rows at the smallest windows (#10).
Plain language: storage-move and clear lines and the Settings left-behind cards name game folders, not git's (#11); held-file and disk-space copy names the operation (#12); the error card's Show details explains and offers Copy details for support instead of rendering raw text (#13).
Release: the MSYS2 and MINGW package sources are pinned and downloaded with
--sources(#16).Game editor: suggests a process name for link starts and says why; the link grace is two minutes (#41).
Docs: D48 records the calls; architecture, ui-guide, developer-guide and the notices are updated. Follow-ups are #52 to #58.
Closes #4, closes #8, closes #9, closes #10, closes #11, closes #12, closes #13, closes #16, closes #21, closes #22, closes #23, closes #35, closes #41, closes #49, closes #50, closes #51
An update of the latest snapshot leaves a folder with nothing unsaved exactly as it was, but reported it like any written folder, so the result and the activity line said it was saved. FolderOutcome gains Skipped (still Ok, no longer Saved); the capture runner sets it where it decides to leave the folder alone, logs a new activity step ('Nothing new in the ... so its latest snapshot stays as it is'), and the partial-result card shows such a folder as 'nothing new, snapshot kept as it was' with the info icon, counting it as already in the snapshot in the card's sentence. Observed reds: LaunchCompleteTests.Updating_the_latest_point_reports_the_folder_with_nothing_unsaved_as_skipped_and_the_other_as_saved failed with 'the install had nothing unsaved and should say it was skipped'; LaunchFlowSessionTests.A_failure_beside_a_folder_the_update_skipped_for_having_nothing_new_says_so_and_does_not_call_it_failed failed on the card body (expected start 'Your game version and mods are in the snapshot...'). Both pass now.A broken skip probe (for example TestLinks.TryCreateFolderLink returning false) turned real tests into skips and the gate still passed. Both gates now always write the xunit report into artifacts/test-results, then tools/SkipCheck compares the skipped test names with build/expected-skips/<os>.txt and fails on any skip the list does not name, printing the names one per line with a count per skip reason. A listed test that now runs is only a note. Lists are keyed by full test name with theory data; ~ marks timing-dependent skips and @include lets the WSL list add to the CI list. SkipCheck --write regenerates a list from a run. gate-linux.sh selects the linux-wsl list; macOS has no list yet. Both gates also run two test modules at once (--max-parallel-test-modules 2). Observed reds (SkipCheckTests, stubs returning empty values): A_list_holds_its_names_... Assert.Equal collections differ; A_skip_the_list_does_not_name_fails_and_is_named Assert.False failure; The_check_exits_with_1_... Assert.Equal 1 vs 0; A_list_that_includes_itself_is_refused Assert.Throws no exception; the reports-below-a- folder and .xunit extension tests failed on Assert.Equal after the real report showed the platform writes .xunit by default. A_test_that_may_skip_... passed on the stub and failed when the Intermittent exclusion was removed (mutation check); the list lint test failed when a duplicate line was added to windows.txt. Done condition shown by hand: with TryCreateFolderLink forced to return false, a run of LinkedFolderTests with the report fails the check, naming the 8 tests that started to skip ("8 x this system cannot make folder links"); restored, it passes.