ProcessStamp.IsRunning counts an unreaped process as running on Linux #35
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#35
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
ProcessStamp.IsRunning(src/Savepoint.Core/Git/ProcessStamp.cs) decides whether the git a killed SavePoint left behind still runs, usingProcess.GetProcessByIdandHasExited. For a process that is not SavePoint's own child, .NET reports a zombie (state Z in/proc/<pid>/stat) as not exited. Where nothing reaps orphans (a container whose PID 1 never waits, or a parent that hangs), the next start or game write could wait on a git that has already finished (D46.1).The Linux process list now skips states Z, X, and x (
LinuxProcessInspector.IsExitedState).ProcessStampshould use the same rule on Linux.Done when a stamped git that is a zombie counts as gone on Linux, with a test.