Prove the layout, accessibility, and job-pill audits can fail #49
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#49
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
From the test-suite review (WARN-001,
.tools/reviews/test-suite/code-review-test-suite.md).If someone breaks one of three audit helpers, about 300 test rows keep passing while they test nothing. That happens whenever a helper edit makes it report no problems. The helpers change as screens grow, so this is a realistic failure.
The helpers are
LayoutAudit.Problems(withIsReachable) intests/Savepoint.App.Tests/Theme/LayoutAudit.cs,AutomationAudit.Problemsintests/Savepoint.App.Tests/Theme/AutomationAudit.cs, and the job-pillCoveredcheck intests/Savepoint.App.Tests/Features/EndToEnd/JobPillPlacementTests.cs. A search of all oftests/found no test that feeds any of them a bad tree; every caller asserts an empty list.StyleGalleryBehaviorTests.The_audit_flags_an_icon_button_without_a_namealready does this for one other helper and is the model to copy.Add one small test per helper with a hand-built tree, and assert which control each problem names:
Buttonoutside the window, one inside a scroll area, a squeezed scroll area, and aComboBoxplaced off-screen. TheComboBoxmatters: dropping it fromIsReachableis a real mutation that a tree of buttons does not catch. DroppingToggleSwitchis not, because it already derives fromButton(unverified against the Avalonia assembly).Button, one named after its type, one named only by an icon glyph, and one named correctly.Coveredstays private, move it besideLayoutAudit.Done when each new test fails under the mutation it targets (make the helper report nothing, drop
ComboBox, makeNeedsNamereturn false, makeTakesTheClickreturn false) and passes on the real helpers.