0.9.18: fast History, one search matcher, after-play and Free up space polish, and cleanup #233
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!233
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-0918"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
History draws only the entries in view (#217, D64.4): a game with 3000 snapshots opens in under 0.2 s headless instead of about 9 s, Tab reaches every card, focus returns to the same snapshot after a search, refresh or resize, and cards name their group and place for screen readers. Template search uses the list searches' matching with its own ranking (#218, D53.3, D53.6, D64.1). The after-play dialog has one footer button and default names use the catalog language's date ("Session - Jul 8, 2026"); Settings' Free up space is named for what it does and says how many Recently removed snapshots it will delete (#159, D44.4). A task stopped so another could go first reads "Stopped" everywhere, every folder open reports a failure on Linux, the keyboard profile menu opens at the row, and the size choice stays in view (#224, #229, D13.17).
Cleanup: LaunchPreview carries its folders as a list (#208); the shell disposes its screens (#220); the VM gate and VM packaging share one VM-wide lock, prune their caches and label narrowed runs from the gate's own verdict (#225 items 1-4, D60.5; item 5, measuring Defender, stays open); the two VM scripts' quoting is fixed.
Each change was implemented test-first and reviewed; review findings and a gap analysis were fixed on this branch. Follow-ups filed: #228 #230 #231.
Local gates on
0d8d6bfc: Windows gate passed (18598 tests, 0 failed, 73 listed skips); Linux gate on the VM passed (18582 tests, 0 failed); two earlier VM runs each hit a different flaky test, filed as #231 and #232 (both pass 4 of 4 alone).Closes #159 #208 #217 #218 #220 #224 #229
The template picker and the editor's Name field now match typed words with SearchQuery/SearchTarget, the same engine as the games list: every word contained anywhere, ignoring case, accents and punctuation, plus a name's initials. TemplateSearch keeps only the ordering (name start, then first-word start, then list order); the ranking now lives on SearchQuery.Rank over the name key. The separate SearchKey/WordsOf engine is gone, so one query finds the same games in both places. Observed reds before the change (assertion failures): - TemplatePickerViewModelTests.A_typed_word_is_found_anywhere_in_the_name_like_in_the_games_search: expected ["Half-Life 2"], actual []. - Accents_make_no_difference_in_the_picker("pokemon"): empty list for "Pokémon Legends: Arceus". - A_typed_accent_finds_a_name_without_it: expected ["Pokemon Legends: Arceus"], actual []. - The_initials_of_a_name_count_in_the_picker: "skyrim se" found nothing. - Initials_alone_find_the_name_they_spell: "sv" found nothing. - A_search_that_matches_only_through_initials_ranks_after_names_that_start_with_it: only "Sv Racing" listed. - The_games_search_and_the_picker_find_the_same_games_for_the_same_text: expected Skyrim SE, actual []. - GameEditorTemplateTests.The_name_field_finds_a_game_by_initials_like_the_games_search_does("skyrim se") and An_accent_typed_in_the_name_field_finds_a_game_without_it: empty match list. Mutation check: ordering by rank descending fails the ranking tests, including Matches_keep_the_given_order_among_equally_good_fits, which passed on its first run. Changed expectations: a word found in the middle of a name now matches ("alflife" finds Half-Life 2), and the match-count announcement test types "alpha one" because "o" is now found inside "Alpha Two".The footer's Not now button repeated the Not now card. The card stays (it explains what happens, can be the preselected choice and is reached with the arrow keys); the footer keeps its one main button, and Escape still leaves the saves alone. Default names of snapshots and profiles used a US numeric date ("Session - 7-8-26"). They now use the catalog language's date pattern with the year ("Session - Jul 8, 2026"), and a date separator or other character a name could not carry on some system becomes a hyphen. Observed reds: - LaunchViewTests.The_post_play_dialog_offers_Not_now_once_while_another_choice_is_selected: Assert.Single() Failure: The collection contained 2 items (card title and footer button). - UiFormatterTests.Default_names_never_hold_a_character_a_name_could_not_carry (fr, dd/MM/yyyy): Expected "08-07-2026", Actual "7-8-26"; Default_names_show_the_year_even_for_the_current_year: Expected "Jul 8, 2026", Actual "7-8-26". - Choosing_the_Not_now_card_and_pressing_the_main_button passed first run (behavior kept); mutation check: with the Skip branch of SaveAsync emptied the test failed, then restored.A player's own Free up space (one game or all games) that a launch preempts ended Cancelled with error.compaction.preempted and read Canceled. JobErrors.WasStoppedForAnotherTask now covers Compact as well as PackStorage, and the Activity title, shell toast and system notification pick new compactStopped / compactAllStopped keys. Observed reds (assertion failures): JobRowViewModelTests.Free_up_space_for_one_game_that_a_launch_stopped_is_called_stopped_not_canceled expected 'Stopped freeing up space for Skyrim Special Edition so another task ...' actual 'Canceled freeing up space for Skyrim Special Editi...'; the all-games row, JobStatusViewModelTests toasts ('Canceled freeing up space for Satisfactory.', 'Canceled freeing up space.') and NotificationTextTests bodies failed the same way.ListSync compared with ReferenceEquals, so the equal records that the card list rebuilds each pass were "moved" onto their own index. ObservableCollection raises a Move even at the same index, and the virtualizing panel treats it as remove plus insert, recycling every drawn row. It now compares with EqualityComparer<T>.Default, so an entry already in place is not touched. The card list is one list to a screen reader: cards are numbered through both groups instead of restarting in each, each card's accessible name leads with its group ("Earlier: <name>, ..."), and the group headings carry heading level 2. Recently removed capped its list at 340 px whatever its length; the cap now applies only to the long list that draws just the rows in view, so a list of 5 to 30 rows takes the room it needs. The focus restore now also puts focus back on the snapshot's own control when focus survived the change inside the list but on another snapshot's control. Observed reds before the fix: - ListSyncTests.New_entries_equal_to_the_ones_shown_change_nothing: collection not empty, three Move events at indexes 0, 1, 2. - ListSyncTests.Equal_entries_that_stay_are_not_moved_while_the_ones_around_them_come_and_go: DoesNotContain failed, Move events for a, c and d. - HistoryVirtualizationTests.A_search_keeps_the_controls_drawn_for_the_lines_it_leaves_as_they_were: Assert.Same failed for "heading:Last 7 days" and "row:bulk-3". - HistoryCardRowsTests.The_cards_are_numbered_through_the_whole_list_not_within_each_group: positions [..., 3, 4, 1, 2, 3, ...]. - HistoryCardRowsTests.A_search_numbers_the_cards_it_leaves_through_the_whole_list_again: [1, 2, 1, 2] instead of [1, 2, 3, 4]. - HistoryCardRowsTests.Each_card_names_its_group_ahead_of_itself_for_assistive_technology: name began "Before the final boss, ..." not "<group>: <name>". - HistoryVirtualizationTests.Each_card_tells_assistive_technology_its_place_in_the_whole_list_and_the_group_it_is_in: position 2338 instead of 2509. - HistoryVirtualizationTests.The_group_headings_are_headings_to_assistive_technology: heading level not 2. - HistoryRecentlyRemovedViewTests.A_list_of_a_dozen_rows_is_drawn_in_full_with_no_scroll_bar_of_its_own: "the list is cut to 340 px of its 1236". - HistoryVirtualizationTests.Focus_that_ends_up_on_another_snapshots_control_goes_back_to_the_snapshot_it_was_on: focused command was the other card's. Passed on first run, checked by mutation: ListSyncTests.Entries_in_a_new_order_are_moved_into_it_and_stay_the_objects_that_were_shown (Move replaced by Insert: order came out [c, a, b, c]); HistoryRecentlyRemovedViewTests.Tab_into_the_rows_of_a_long_list_scrolls_the_screen_so_the_focused_row_shows (page scroll disabled: failed); A_long_list_scrolls_inside_its_section pins the long case the new style keeps.A_settings_write_that_landed_but_cannot_be_read_back_leaves_the_storage_in_the_new_default freed the held settings file after a fixed 1600 ms. The write's own read-back retries for about 1.3 s, and the startup check's re-read starts only after that gives up. On a slow runner the timer ran out during the write's retries, so its read-back succeeded, the re-read path never ran, and the log had no "the settings name" line. Observed red (hold shortened to 1000 ms to stand in for a slow runner): the same assertion as on CI, Assert.Contains() Failure: Filter not matched in collection, at the "the settings name" line. The hold is now freed when the log shows the write gave up ("the settings could not be changed to"), so the re-read is always the first read to find the file free. A 30 s deadline frees it if that line never comes.