Dispose the screens when the shell is disposed #220

Closed
opened 2026-10-27 04:51:05 -05:00 by ethan-hann · 1 comment
Owner

ShellViewModel.Dispose does not dispose the screens it holds (_screens), so GamesScreenViewModel.Dispose, ProfileSearch.Dispose and the new HistoryScreenViewModel.Dispose (which stop search and typing-pause timers and cancel a read in flight) run only in tests. Dispose each screen the shell built when the shell is disposed, and add a test that a screen's timers stop when the shell goes.

ShellViewModel.Dispose does not dispose the screens it holds (`_screens`), so GamesScreenViewModel.Dispose, ProfileSearch.Dispose and the new HistoryScreenViewModel.Dispose (which stop search and typing-pause timers and cancel a read in flight) run only in tests. Dispose each screen the shell built when the shell is disposed, and add a test that a screen's timers stop when the shell goes.
ethan-hann added this to the Code Cleanup milestone 2026-10-27 04:51:05 -05:00
Author
Owner
Fixed in 0.9.18 (PR 233): https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.18
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#220
No description provided.