History takes seconds to draw a game with thousands of snapshots #217
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#217
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The History screen's lists are not virtualized: every snapshot card is built and laid out. In a headless measurement a game with 3000 snapshots took about 10 s to lay out, before any search; narrowing a search to one card took 196 ms and clearing it again took 8 s. Filtering in the view model is instant, so the cost is in the views. A player with months of sessions on a mid-range PC would wait on every visit. Virtualize the History timeline and Saves column (and Recently removed), keep keyboard navigation, focus restore and screen-reader names working, and add a timing test with a few thousand snapshots.
Fixed in 0.9.18 (PR 233): https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.18