ArtworkContractTests can count one more artwork event from the real backend than the fake #231
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#231
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Savepoint.App.Tests.Contract.ArtworkContractTests.The_real_backend_tells_the_same_artwork_story_as_the_fakefailed once in a full Linux VM gate on integration-0918 (331d087f) with "fake: events after looking: 3 / real: events after looking: 4" and "events at the end: 5 / 6", then passed 4 of 4 runs of the class alone on the same VM. The real backend sometimes raises an extra artwork-changed event (likely a refresh racing the lookup) that the story counts. Find which event is extra, then either make the real backend not raise a duplicate or make the contract compare the artwork states the events lead to instead of raw counts. No retries exist any more (D60), so a flake fails the gate.Fixed in 0.9.19 (PR 252): https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.19