Fixes from the Linux desktop checks: switch dialog sizes, sidebar picking, small-window cards #90

Merged
ethan-hann merged 15 commits from integration-096 into main 2026-10-24 17:16:18 -05:00
Owner

Groups the fixes for the issues the second round of Linux desktop checks (#3) turned up, plus the small-window card fix.

  • Launch cards in a short Games pane (#84): below 300 px of pane height the launch banner and the checking and running cards scroll with the profiles instead of staying pinned, so the pill and the toasts never cover their text or the Cancel button. The pill-placement tests no longer skip those screens.
  • What a switch removes (#86): the switch and Go back dialog now says how much a switch removes, sized from the stored snapshot (one cat-file batch, never reading the folder). A case-only rename on a system that ignores case counts as replaced, not removed, matching what the switch does.
  • Save count wording (#87): the count includes the saves a profile started with when it was made from another one; the subtitle now reads "N save snapshots to choose from" and the user guide explains the sharing.
  • Picking a game in the sidebar (#88): arrowing only marks a game; a click, Enter or a screen reader's invoke opens it, even when it is already selected, closing Help and leaving Settings. Rail and shelf game items expose an invoke pattern.
  • Rail button labels (#89): both rail buttons wrap their label inside the button, and the icon rail keeps both icons centred.
  • Docs: UI guide, user guide, architecture and D40 updated; the developer guide notes the sources download row on releases.

Each branch had an Opus review; the findings (case-only renames, screen-reader activation, compact icon, weak tests) are fixed here. The Windows gate runs locally before merge.

Closes #84
Closes #86
Closes #87
Closes #88
Closes #89

Groups the fixes for the issues the second round of Linux desktop checks (#3) turned up, plus the small-window card fix. - **Launch cards in a short Games pane (#84):** below 300 px of pane height the launch banner and the checking and running cards scroll with the profiles instead of staying pinned, so the pill and the toasts never cover their text or the Cancel button. The pill-placement tests no longer skip those screens. - **What a switch removes (#86):** the switch and Go back dialog now says how much a switch removes, sized from the stored snapshot (one cat-file batch, never reading the folder). A case-only rename on a system that ignores case counts as replaced, not removed, matching what the switch does. - **Save count wording (#87):** the count includes the saves a profile started with when it was made from another one; the subtitle now reads "N save snapshots to choose from" and the user guide explains the sharing. - **Picking a game in the sidebar (#88):** arrowing only marks a game; a click, Enter or a screen reader's invoke opens it, even when it is already selected, closing Help and leaving Settings. Rail and shelf game items expose an invoke pattern. - **Rail button labels (#89):** both rail buttons wrap their label inside the button, and the icon rail keeps both icons centred. - **Docs:** UI guide, user guide, architecture and D40 updated; the developer guide notes the sources download row on releases. Each branch had an Opus review; the findings (case-only renames, screen-reader activation, compact icon, weak tests) are fixed here. The Windows gate runs locally before merge. Closes #84 Closes #86 Closes #87 Closes #88 Closes #89
In the library layout at 460 px or less the shelf leaves the pinned launch banner, running card and checking card no room above the toast stack and the job pill, so a toast could cover them. Below 300 px of pane height the card now sits below the profile table in the scroll area (as the failure card already does) and is brought into view when it arrives. The skip for these cases in JobPillPlacementTests is removed.

Observed reds before the change (JobPillPlacementTests, Library layout, skip removed): No_control_under_the_toasts_..._under_them games-checking: Button 'CancelButton' is under the pill at 184,320 (smallest window); games-running and games-banner: pinned text under the pill; A_full_height_toast_stack_and_the_pill_cover_nothing_in_the_smallest_window for all three; No_control_under_the_pill_and_the_toasts_together games-running at 460, 432 and 420. New GamesScreenViewModelTests case checked by mutation (< to <= on the threshold failed it).
The view comments and the UI guide still described the launch banner
and the checking and running cards as always pinned; below a 300 px
pane they now scroll with the profiles. D40's note on the banner gains
the same case.
The release page now carries a link attachment to the git-sources
release, so the sources show in the downloads list beside the packages
and not only in the notes.
The switch dialog sized "files will be replaced" from the target point's
bytes, so a file the target does not have (removed) added nothing: going
back over a 600 MB file said "About 3 bytes". Sizes now also carry the
bytes of the files a switch removes, read from stored object sizes only
(no file on disk is read or hashed), and the dialog adds its own sentence
"About N of files will be removed." A removal-only switch skips the
replaced sentence.

The save picker's count comes from the profile's whole save lineage, so a
profile made from another one counts the saves it started with. The
subtitle said "in this profile"; it now says the saves are to choose from,
including any from the profile this one started from.

Observed reds:
- SwitchStatTests.A_switch_summary_sizes_the_files_it_removes_by_what_the_folder_holds_now: Expected 2, Actual 0 (BytesRemoved)
- LaunchDialogViewModelTests.Files_the_switch_removes_are_sized_in_their_own_sentence and
  A_switch_that_only_removes_files_says_so_without_a_replaced_amount: Actual "." / no removed sentence
- LaunchDialogViewModelTests.Several_saves_are_offered_in_a_picker_with_the_tip_selected and
  One_save_is_shown_as_text_with_no_picker: subtitle still "in this profile"
- LaunchIgnoredFileTests removed-bytes assertion passed on first run; mutation
  (pass 0 instead of diff.BytesRemoved) failed it: Expected 15, Actual 0
The profile record names no source profile, so nothing reliable says whether
a profile was made from another one; the clause about the profile it started
from would be wrong for a root profile. The subtitle now just says how many
save snapshots there are to choose from. The style gallery sample matches.

Observed red: the expectations in LaunchDialogViewModelTests (Several_saves_are_offered_in_a_picker_with_the_tip_selected, One_save_is_shown_as_text_with_no_picker) were changed together with the catalog text, so no separate red run was taken; the previous commit's text fails them (extra clause after 'to choose from').
Choosing a game in the sidebar list only marked it, so with Settings open and
the game already selected, clicking it did nothing. Selection now only marks
the game (arrowing never leaves a half-filled page); a click or Enter on a
game opens it, and opening a game closes the help page and leaves Settings.
The shelf uses the same handlers.

The "Add games from your libraries" label sat in a row that never limited its
width, so it ran into the button's edge. It now wraps inside a grid cell with
more side padding.

Observed reds:
- ShellViewModelTests.Moving_the_game_selection_leaves_the_current_screen_alone:
  Expected Settings, Actual Games
- ShellViewModelTests.Opening_a_game_while_the_help_page_is_open_over_games_closes_the_page:
  IsNotType failure, Content was still HowItWorksViewModel
- ShellViewTests.Clicking_a_game_in_the_rail_opens_it_from_settings_even_when_it_is_already_selected(index: 0):
  Expected Games, Actual Settings
- ShellViewTests.Clicking_a_game_in_the_rail_closes_the_help_page: Content still HowItWorksViewModel
- ShellViewTests.Arrowing_through_the_rail_keeps_settings_open_and_enter_opens_the_game:
  Expected Settings, Actual Games (arrow), then Enter did nothing
- ShellViewTests.A_rail_button_label_keeps_clear_of_the_button_edge_and_is_not_cut_off(RailLibrariesButton):
  label ends -7px from the button's right edge
Mutation check: sending Activity instead of Settings to Games in SelectGame
failed the opening-from-settings and help tests; restored.
On a system that ignores case, Data/Foo.BSA and Data/foo.bsa are one file, and
the switch plan already leaves a deleted name out of the removals when the
target holds it under another spelling. The summary now applies the same rule
(the file-name comparer of the folder), so its removed count and size match
what the switch does. The history diff is unchanged. Only deleted paths have
their old size looked up, and the doc comment says the removed size is read at
the point the folder is on.

Observed red: SwitchStatTests.A_case_only_rename_is_replaced_not_removed_on_a_system_that_ignores_case, Expected: 0 Actual: 1 (FilesRemoved).
Rail and shelf game lists now use a list whose items expose an Invoke
automation pattern that opens the game like a click does; before, a screen
reader activating a game only marked it. Enter opens the focused item, not
the selected one. The library button's wide padding no longer applies in the
icon rail, so its icon stays centred like the Add button's. The Add a game
label wraps in a grid like the library button's, so a longer translation
cannot overflow.

Observed reds:
- ShellViewTests.Invoking_a_game_through_accessibility_opens_it_from_settings
  (RailGames, ShelfGames): IsAssignableFrom IInvokeProvider failure, the peer
  had no Invoke pattern
- ShellViewTests.In_the_icon_rail_both_buttons_centre_their_icon: icon offset
  outside -1..1 (padding 16 left 9px for the icon)
- ShellViewTests.A_rail_button_label_wraps_so_a_longer_translation_cannot_overflow
  (RailAddButton): expected Wrap
- ShellViewModelTests.Opening_a_game_while_the_help_page_is_open_closes_the_page
  (now returns to Settings afterwards): with the ClosePane block removed,
  IsNotType failure, Content was HowItWorksViewModel; restored
Not discriminating: Enter_opens_the_focused_game_even_when_it_is_not_the_selected_one
passes with a selection-based handler too, because Enter selects the item first
in this Avalonia version; the handler still reads the focused item.
Merge branch 'issue-88-sidebar-fixes' into integration-096
Some checks failed
Gate / linux (pull_request) Failing after 10m46s
ee5c011c9a
Accept the game list's own item type in the focus survival test
All checks were successful
Gate / linux (pull_request) Successful in 12m5s
Gate / linux (push) Successful in 12m1s
b99180c0e5
The rail and shelf lists now hold GameListBoxItem, a ListBoxItem with an
invoke pattern, so the exact-type check failed.

Observed red (Windows gate): Assert.IsType() Failure, expected
ListBoxItem, actual GameListBoxItem, for RailGames and ShelfGames.
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint!90
No description provided.