The Go back dialog's size estimate ignores files the switch will remove #86

Closed
opened 2026-10-24 16:14:26 -05:00 by ethan-hann · 0 comments
Owner

On Linux (0.9.5, VM checks round 2 on #3), Go back to an older snapshot said "About 3 bytes of files will be replaced" while the switch then removed a 600 MB file that the folder held. The estimate seems to compare the target with the loaded snapshot rather than with what the folders hold now, or it counts only files that are replaced and not files that are removed. A player deciding whether to go back should see the real amount of change. Check how the estimate is computed (likely the same path on Windows), and make it count added, replaced and removed files against the current contents.

On Linux (0.9.5, VM checks round 2 on #3), Go back to an older snapshot said "About 3 bytes of files will be replaced" while the switch then removed a 600 MB file that the folder held. The estimate seems to compare the target with the loaded snapshot rather than with what the folders hold now, or it counts only files that are replaced and not files that are removed. A player deciding whether to go back should see the real amount of change. Check how the estimate is computed (likely the same path on Windows), and make it count added, replaced and removed files against the current contents.
ethan-hann added this to the 1.0 milestone 2026-10-24 16:14:26 -05:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#86
No description provided.