0.9.21: a leaner, faster test suite, the App tests in parallel lanes, and a clean quit noticed in seconds #264
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!264
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-0921"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
An audit of the 19,087-case suite found about 3,000 Core theory rows that asserted nothing, about 400 duplicated checks, render tests that only checked a file's size, fakes with no contract behind them, and a CI time dominated by about 970 slow cases and a small Windows CI VM (D70). This batch fixes that without changing product behavior beyond #255:
Reviewed by an Opus code review (0 critical; warnings fixed) and a gap analysis (doc gaps fixed). Follow-ups: #256-#263.
Local gates on
d7d257c5: Windows gate passed (3666 App test methods in three lanes, count check matched; Core 11m06s, App lanes 2m56s to 5m26s); Linux gate on the VM passed (lanes, about 8.5 min in total).Refs #255 (kept open until Balatro is retested)
The saves and mods rules looped over parts of the shipped data that only some templates carry, and the one count guarding them was met by the Windows saves folders alone. A new count checks each system's saves and mods folders, the per-system entries, the store names, the notes and the link launches. The check over the shipped templates now has a test that can fail, a rule that throws on one template is reported for that template instead of ending the loop, and the SavesByOs and ModsByOs branches have a case that feeds them to the rules. Observed with the code broken on purpose: - SavesPaths without its SavesByOs branch: ShippedTemplatesTests.The_data_each_rule_loops_over_is_there_in_every_part_the_rules_check failed with "Linux saves folders: 0, expected at least 40" and "macOS saves folders: 0, expected at least 60"; TemplateRulesTests.The_per_system_folders_of_a_template_reach_the_saves_and_mods_rules_under_their_own_system failed with Expected [("linux", ...)] Actual []. - AssertShippedTemplatesKeep with problems.Count >= 0: The_check_over_the_shipped_templates_fails_when_a_rule_finds_a_problem failed with "No exception was thrown". - ProblemsIn without the catch: A_rule_that_throws_on_one_template_is_reported_and_the_templates_after_it_are_still_checked failed with the rule's own exception escaping.