Decide how long to watch for a store relaunch after a clean quit #256
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#256
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Since #255, when the game's own program quits with exit code 0 inside the 30 s relaunch window, the session ends two process-list looks (about 4 s) later instead of after the 2-minute grace (D13.10). That fixed Balatro, which was held up for two minutes after a quick quit. A game that relaunches itself through its store and exits with code 0 now gets only those 4 s for the new copy to appear; if the store is slower, the after-play choices show early, and the after-play guard (D67.5) refuses a snapshot while the game runs (Choose again).
Check real games on Steam, GOG and Epic that relaunch through their store, note their exit code and how long the new copy takes to appear, and decide whether the 4 s is enough or should be longer (for example 10 s) for a clean exit. Also confirm Balatro's exit code on Windows (the log now records it).
0.9.21 narrowed the clean-quit rule: the short wait applies only after the program ran for at least 10 seconds (CleanQuitMinimumRun); a clean exit sooner is treated as a relaunch stub and keeps the full grace (D13.10). The real-store check in this issue should confirm 10 seconds is right.