0.9.14: warn about cloud saves only when the store syncs them, with advice that matches what Steam and GOG Galaxy do #155
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!155
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-0914"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #152, #153 and #154.
The editor told every player to turn off cloud saves. Tests with real clients (Balatro on Steam on two PCs, Deus Ex on GOG Galaxy) showed both stores keep the saves SavePoint changes and upload them, restore saves SavePoint removed at the next launch, and that Steam asks (Cloud Conflict) rather than overwriting when a second PC has a newer copy. D56 records the findings.
SavePoint now reads each game's cloud setting: Steam's cloudenabled in the active account's sharedconfig.vdf (a missing key with remotecache.vdf present reads as on), and GOG Galaxy's ProductSettings.cloudStorage from a copy of galaxy-2.0.db (Windows only, never the live file, checked for a torn copy, cached per session). The note shows per store only when cloud is on or unknown, and follows edits to the app id, folder and launch link. Microsoft.Data.Sqlite is added for the Galaxy read and left out of the Linux and macOS publishes.
Also: the developer guide and AGENTS.md now say CI gates pull requests only and the docs site publishes from main only. Version 0.9.14.
Each change was reviewed by a separate reviewer and fixed. The full Windows gate passed locally (15,589 tests).
A new GetCloudSavesAsync(CloudSaveQuery) overload takes the install folder, Steam app id and launch link from the form, so the check works before a game is saved. The editor asks again 400 ms after the last change to the app id or folder; each change cancels the pause and bumps a version counter, so an answer to an earlier question (including the first load) never replaces a newer one. Observed reds: - GamesApiCloudSavesTests: 4 new tests failed against a stub overload that returned Unknown/None (Expected On/Steam, Actual Unknown/None; Expected Gog, Actual None; the bad token expected a failure, got success) - GameEditorCloudSavesFollowTests: 6 of 6 failed before the editor re-checked ("The editor never got that far" from the polling helper, since no second check was made) Mutation check: dropping the version and cancellation guards made the late-answer test and the first-load test fail.The first load now takes its version when the editor is built and no longer bumps it, so an edit made while the folder status loads is the newer question and its answer is kept. Closing the editor counts as a newer question; the version is the only guard. A changed launch link or start method also re-runs the check. The form overload returns Unknown for a half-typed or unresolvable folder instead of failing, so typing does not log a warning at every pause. The fake honors a cancelled token and a queued failure like the real Api, and the contract scenario covers the overload (form, half-typed folder, cancelled). Adds a test that the Microsoft.Data.Sqlite pins equal the versions the pinned nuspecs depend on, and a csproj note that the condition reads RuntimeIdentifier. Observed reds: - GameEditorCloudSavesFollowTests: An_edit_made_while_the_folder_status_is_still_loading_keeps_its_own_answer (note started with the Steam text, Expected the unknown text); the two launch link tests timed out ("The editor never got that far") - GamesApiCloudSavesTests: the bad-token form (Expected Ok True, Actual False) - BackendContractTests: fake answered the cancelled form check with success, real with error.operation.cancelled Mutation checks: removing the version guard failed the late-answer and the closed-editor tests; removing the version bump in Dispose failed the closed-editor test; changing a dependency in the Microsoft.Data.Sqlite nuspec failed the pin test.