Read each game's cloud-save setting and warn only when it is on, with accurate advice #152
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#152
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The game editor always says to turn off the store's cloud saves, or the store can sync older saves over the ones SavePoint puts back (gameEditor.cloudSaves, README, user guide, D-entry near decisions.md line 177). A test on the Linux VM with Balatro and Steam Cloud on showed that advice is wrong for one PC: Steam does nothing while the game is closed, and at the next launch it compares each file's sha1 with its own cache, keeps the local files ("SHA mismatch with cache - setting local changes"), and uploads them when the game exits. No conflict dialog appeared and no local file was overwritten, for new content, older content, preserved old mtimes, and older content over a newer cloud copy. The remaining risk is a second PC (or a cleared Steam cache) holding a newer cloud change: then Steam may ask which copy to keep or download over the files SavePoint put back. That case was not reproduced.
What to build:
Tests use fixtures built from the real file layouts (vdf text, a SQLite file with the real table shapes), covering on, off, missing key, missing file, and no store installed.
Shipped in 0.9.14 (pull request 155).