Real progress for big snapshots, and keep working while one runs #47
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!47
Loading…
Reference in a new issue
No description provided.
Delete branch "issue-37-snapshot-progress"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #37 and #46.
Reproduced first with three 1.5 GiB random files plus 20 small ones, the bundled git, and SavePoint's repo config: git add printed nothing for the whole add, and both progress reports arrived together at 125 s after about 4.8 GB was written, so a count of files cannot move during a big file. The combined bar also waited for both folders to report a total, which is why the total was missing ("1 files copied so far"). What does grow is objects/pack/tmp_pack_* (files above core.bigFileThreshold stream into it): 9 MB at 0.5 s, 283 MB at 5.6 s, 4.8 GB at 103 s, ending at about the source size for incompressible data; then about 22 s of finalising with nothing growing. On Windows the size is only live when the file is opened with shared access and its length read.
Re-run with the fix on the same data: the first event at 0.1 s with the byte total, 185 progress events, 314 MB at 5.7 s, 2.2 GB at 42.7 s, 4.7 GB at 92.3 s. Not yet seen on a real 70 GB game in the live app. Compressible data reads low until the end, because the store holds compressed bytes (#45 is the pack.compression call).