Remove the last "so far" progress wording #46
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#46
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The first-snapshot wizard no longer says "N files copied so far"; it shows bytes of a known total, or says it is still working out how much there is. Two places still use the old wording: the launch dialog switch progress (LaunchDialogViewModelTests:299 asserts "12 files copied so far") and Activity (activity.progress.filesSoFar). Use the same byte progress and copy where the job reports bytes.
Fixed in
aa6008f, merged with PR #47: the switch dialog, the save views, and Activity share the wizard progress wording (ProgressWording), and the so-far catalog keys are removed.