Capturing a profile for a game does not update the dialog and no way to run in background #37
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#37
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happened
Initial profile snapshot of a large game statically shows only "1 files copied so far" even after multiple minutes of waiting.
The actual underlying git operations appear to be running, just not updating the UI's status:

There is also no "Run in background" on the dialog so user's are forced to wait until the operation completes. Users could take that time to continue adding their games instead.
Other game example

What you expected to happen
I expected the dialog to show accurate progress of the git operations being performed and I expected to be able to minimize the dialog while the job continues running in the background. Progress could be checked from the Activity screen.
Steps to make it happen again
Your setup
Log
Cause, from the screenshots and the code path: the snapshot progress counts whole files, and git reports a file only when it has stored all of it, so a multi-gigabyte archive holds the count still for minutes (Control: Resonant, with 445 smaller files, moves normally). The file total was also missing here, hence "1 files copied so far" with an indeterminate bar.
Planned fix for 0.9.1: progress in bytes measured from what git writes into the snapshot folder, plural-correct copy, and a Keep working button on the Create step that leaves the snapshot running as a job (Activity, the status pill, a notification when it finishes) so the next game can be added meanwhile. It will be checked against a real multi-gigabyte reproduction before it ships.