0.9.5: add games from your libraries, 320 game templates, Linux desktop fixes #85
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!85
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-095"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Add games from your libraries (#70, D52): a checklist of the installed Steam and GOG games, matched to templates, confirmed once with every folder named, added through the single add's checks. GOG Galaxy's own folders are protected like Steam's. Games started through a store link get a suggested process name.
Templates for about 320 games (#69, D53): every template checked against its PCGamingWiki page through its Steam app id; 152 carry a saves folder, the rest say why the player picks it. Linux and macOS drafts use only their own entries. The template picker searches and keeps its buttons in view.
Sessions (#74, D48.7): a game started directly that relaunches through Steam is followed to the new copy instead of ending after a second; a normal quit still ends at once, and the wait is never counted as play time.
Toasts float over the shell instead of pushing it up (#73); the page lifts its pinned content above them.
Linux, found on a real Ubuntu 26.04 desktop: GNOME banners now show (one D-Bus connection kept open, #75), a second start raises the first window (#76), the window class matches the desktop entry and a missing display prints a plain message (#78), a case-only name clash on a case-insensitive drive is refused before anything is written (#77), the switch dialog names only what changes, the tour card keeps off the profile rows, and a flaky session test is deterministic (#79).
Bundled git sources move to their own release (git-sources-2.56.0.2), so app releases list only the app downloads (D21).
Each part was reviewed by Opus and the findings fixed here. Version 0.9.5.
Closes #69, closes #70, closes #73, closes #74, closes #75, closes #76, closes #77, closes #78, closes #79
A template file can now carry an optional libraryHints block beside the definition: extra Steam app ids, Steam install folder names, GOG product ids and folder names, and a saves folder per operating system. The block is read from the same text and never becomes part of a stored game, so old templates and exported definitions are unchanged. A draft takes the saves folder written for its operating system when there is one. The Skyrim template now names its Steam app id and install folder. Observed reds (TemplateLibraryHintsTests, hints read as empty and drafts ignoring the system): - The_hints_block_is_read_next_to_the_definition: Collections differ, expected [4243, 4244], actual []. - A_draft_uses_the_saves_folder_written_for_its_operating_system: Strings differ, expected "{userHome}/.local/share/Alpha/saves", actual "{documents}\\Alpha\\Saves". - The_skyrim_template_names_its_steam_folder_and_app_id: Values differ, expected 489830, actual null. Passed on first run, kept by reasoning (no member to mutate): The_hints_never_become_part_of_the_stored_definition.GameTemplates now discovers the embedded template resources (sorted by name) instead of a hand-kept file list, so adding a template is one new file. ShippedTemplatesTests checks each template that ships: unique kebab-case id and name, positive Steam ids, single safe store folder names, numeric GOG ids, saves folders that resolve through the real token resolver on the system they are written for, and notes free of banned words and em dashes. Observed reds, in order: - Every_embedded_template_file_is_loaded with a second template file present: Assert.Equal() Failure, Expected [skyrim-se, zz-broken], Actual [skyrim-se]. - Saves_folders_resolve_on_the_system_they_are_written_for(zz-broken), a throwaway template using {nowhere}: '{nowhere}\Broken\Saves' does not resolve on windows: validation.path.unknownToken. The throwaway file is not committed.ToDraft(OsKind) fell back to the definition's saves folder even on Linux and macOS, where {localLow}, {savedGames} and Windows drive paths mean nothing, so adding such a game failed. The draft now has no saves folder there (the editor already explains an empty one); a per-system entry still wins, and {documents} and the other shared tokens carry over. Observed red: Draft_leaves_the_saves_folder_blank_when_a_windows_only_token_has_no_meaning_here for Linux and MacOS, Assert.Null() Failure, Actual ExternalLocation { Path = {localLow}\Studio\Game }. The token sets are checked against the real platform token tables by The_token_names_a_draft_checks_are_the_ones_each_platform_defines, which passed first run; removing localLow from the Windows set failed it and Draft_on_windows_keeps_the_windows_only_tokens, then restored.The add now puts in only the folders the player was shown: the install folder the scan named, and the saves folder only when the scan found it and it is still there. A saves folder that appeared after the confirmation, or a draft that names other folders, is left out (the result names it). Scan and add use one rule for "already added": a Steam game is judged by the id it is installed under (a GOG copy of a templated game is no longer called added because the Steam copy is), and a saves folder another game already tracks counts, since adding over it would be refused. A template's program replaces the store launch only on Windows and when it is in the install folder. Installed folders that hold another installed game's folder are not offered, GOG folders must be fully qualified, install folder names Windows would trim are refused, apps sharing a folder are merged after template matching so the described app wins, and Snap Steam is found. The scan reads the stores outside the storage gate and takes a token checked per library and record. A game added with a store link gets the program to watch from the process name suggester, so its session can end by itself. Observed reds (assertion failures): - A_saves_folder_made_after_the_scan_is_not_added_...: left-out path was null. - Only_the_folders_the_scan_showed_are_added_...: stored install was the draft's, not the scanned folder. - A_gog_copy_of_a_templated_game_is_not_called_added_...: AlreadyAdded. - A_steam_edition_matched_by_a_hint_keeps_its_own_app_id_...: expected 778, actual 777. - Where_a_windows_program_cannot_run_the_store_launch_is_used (Linux, macOS): expected Uri, actual Exe. - A_folder_that_holds_another_installed_games_folder_...: expected ["gog:2"], actual both. - A_game_that_starts_through_a_store_link_gets_the_program_to_watch_...: process name was null. - A_folder_that_is_not_fully_qualified_... (3), An_install_folder_name_that_ windows_would_trim_... ("...", ".. "), Linux_finds_the_snap_package_... (expected the snap folder, actual null), A_game_whose_saves_folder_another_ game_already_tracks_...: all failed on their assertions. Mutation-checked after passing first time: the scan outside the storage gate (read it inside the gate, the exclusive-gate test failed) and the token checks (removed, the cancelled-scan test failed).Closing the window while games are being added now asks first, like a job does: the run registers with a tracker, the exit guard asks "SavePoint is still adding your games", and quitting asks the run to stop after the game it is on and waits for that game. The run dialog always ends in a state that can be closed: an exception in one add is reported for that game and the games not reached count as not tried. Closing the checklist cancels its scan (the token reaches the per-library and per-record checks) and the flow no longer waits for a scan the player gave up on, so a dead network drive cannot keep the command busy. GOG Galaxy's program folder and its Games folder (read from HKLM ...\GalaxyClient\paths, Windows only) are tier-two protected like Steam's folders. The confirmation labels the game folder and uses the single-add wording ("takes snapshots of everything in these folders") and says plainly that no snapshot is taken now; a row's screen reader name holds the install folder, so two copies of a game differ. The checklist was checked to draw only the rows in view for 200 games. The new rail and shelf entry sits where it is drawn, so the tab-order expectations now list it before "Add a game". Observed reds (assertion failures): - LibraryRunExitTests.Staying_open_leaves_the_run_alone: expected False, actual True (no question was asked); Quitting_asks_the_run_to_stop_and_ waits_for_the_game_it_is_on: Assert.True failed. - LibraryAddDialogViewModelTests.A_game_whose_add_throws_ends_the_run_cleanly _and_can_still_be_closed: InvalidOperationException : boom escaped. - LibraryPickerDialogViewModelTests.Closing_the_dialog_cancels_the_scan_it_ started (cancel, dismiss): token not cancelled. - LibraryImportFlowTests.Backing_out_while_the_scan_is_still_running_ends_ the_flow_at_once: TimeoutException after 5 s. - GogFolderProtectionTests.Galaxys_program_folder_and_its_games_folder_are_ tier_two and the case test: not blocked. - LibraryConfirmDialogViewModelTests (message wording, install line) and the row automation name test: strings differed. - TabOrderTests, six tests: expected "Add a game", actual "Add games from your libraries" (the new entry is drawn first), then updated. Mutation-checked after passing first time: the tracker registration (two tests failed), checklist virtualization (a plain StackPanel drew all 200 rows, the test failed), the editor/dialog paths from the previous commit.A shared token such as {documents} or {appData} says nothing about where a Windows game saves on Linux or macOS (under Proton the saves are inside the game's prefix, and native ports use their own folders), so carrying the Windows default over pointed SavePoint at folders the game never writes. ToDraft now uses the template's savesByOs entry for the system and leaves the folder blank otherwise; Windows keeps the default. The token-set helper and its test are gone because nothing needs them. Observed red: Draft_leaves_the_saves_folder_blank_without_an_entry_for_that_system (Linux and MacOS), Assert.Null() Failure, Actual ExternalLocation { Path = {documents}\My Games\Game }. Two existing tests also changed: A_draft_keeps_the_old_shape_when_there_are_no_per_system_folders now drafts for Windows and checks the Linux draft is blank, and A_game_with_no_template_is_offered... failed (Assert.Null() Failure, Actual counter-strike-source) because Counter-Strike: Source now ships as a template, so it uses an app id no template names.New theories over every shipped template: - A_saves_folder_does_not_end_in_a_file_name_or_a_wildcard - No_saves_folder_is_another_games_folder (compares each path segment with the other templates' names, ignoring case, spacing and years) - Linux_and_macos_drafts_use_only_their_own_entry - A_saves_folder_is_not_one_of_the_platforms_broad_folders (judged against each platform's real denylist) Observed reds on the data as it stands (fixed in the next commit): minit Linux ends in minit_v1.sav, the Force Unleashed macOS path ends in SWTFU.BIN, Rise of the Tomb Raider's macOS path is the Shadow of the Tomb Raider folder, and Batman: Arkham Asylum GOTY's macOS path is the Arkham City GOTY folder. Throwaway proofs, not committed: a template with {appData} as its Windows folder and {userHome} and {documents} as its Linux and macOS folders failed the broad-folder test ('{appData}' (windows) is C:\Users\Test\AppData\Roaming; '{userHome}' (linux) is /home/test); making ToDraft carry the Windows default over again failed the draft test for 109 templates.A profile holding Mods/Foo and Mods/foo, switched onto a folder on an exFAT drive mounted on Linux, wrote both files into one folder and then failed the cleanup with the "something else is holding a file open" message. Nothing compared the names inside one point with each other, only a file against a folder. A switch and a discard now read the point's whole tree before writing and refuse with error.launch.caseClash (names both spellings, writes nothing) when the work tree compares names without case. The probe that finds such a drive now asks about the marker file inside the folder first, so a game folder that is the root of a mounted drive is recognised too (its parent lives on another drive and said nothing). Observed reds before the fix: - CaseClashTests.Two_folders_that_differ_only_in_case_clash_at_the_first_part_that_differs: Expected ("Mods/Foo", "Mods/foo") but was null (likewise the two-file and file-and-folder cases) - CaseClashTests.A_point_holding_two_names_that_differ_only_in_case_is_refused_before_anything_is_written (Switch, ForcedSwitch, Discard): Assert.IsAssignableFrom failure, value is null (the operation succeeded) - CaseClashTests.A_drive_that_ignores_case_is_found_out_and_the_clash_is_refused_without_being_told: same, on NTFS - FileFolderCollisionTests.The_root_of_a_drive_that_ignores_case_is_found_out_from_the_marker_file_it_holds and The_marker_file_decides_over_the_folders_parent_when_the_folder_holds_one: Assert.True / Assert.False failures - ErrorCardViewModelTests.Two_names_that_differ_only_in_case_...: title was "Something went wrong" Mutation checks: dropping the spelling comparison in FindCaseClash failed the no-clash guard; forcing a clash failed A_point_holding_one_spelling_of_each_name_switches_as_before. Also run on a Linux VM with the temp folder on an exFAT loop mount: CaseClashTests 9 of 9, FileFolderCollisionTests 54 passed, 2 skipped.Every template was checked against its wiki page (the page is found by Steam app id and its infobox must name that id). Where the wiki has a Steam row, a Steam-matched template uses it, and is left blank when that row is Steam's userdata folder unless the Windows folder exists on this machine for that game, which shows the Steam copy still saves there. Fixes: Hades uses {documents}\Saved Games\Hades (not the Saved Games known folder); HITMAN 3 was built from the Hitman: Contracts page, so it is now HITMAN World of Assassination with Steam id 1659040 and no GOG id; Cyberpunk 2077 gets Steam id 1091500; RimWorld uses the RimWorld by Ludeon Studios folder and drops the Linux guess; the Arkham Asylum and Rise of the Tomb Raider macOS paths named other games and are gone, as are the Lies of P macOS, Force Unleashed macOS (a file) and Metro Exodus Enhanced Linux entries the wiki does not support; Minit's Linux and macOS paths name the folder, not minit_v1.sav; Linux paths use {localAppData} and {appData} where the wiki uses the XDG folders; 25 saves folders the wiki gives (Starfield, A Plague Tale: Innocence and others) are added and 13 whose only wiki location is Steam's userdata folder are blanked; the notes say "Steam's userdata folder"; Dead Space and Lords of the Fallen carry their years. Two tests pin the corrections. Mutation check: putting Hades back to {savedGames}\Hades failed Games_checked_against_their_wiki_page_keep_their_corrected_facts (Strings differ, Expected {documents}\Saved Games\Hades); restored.The template picker's 'No games match your search.' line is a polite live region so a screen reader announces it. The test also pins that the search field has the keyboard focus when the picker opens. Observed red: The_template_picker_dialog_lists_the_built_in_templates, Assert.Equal() Failure, Expected Polite, Actual Off. The focus assertion passed on its first run, so it got a mutation check: Focusable=False on the field failed it ('The search field has the keyboard focus as soon as the picker opens'), then restored. The folder-confirmation view test took the first template, which was Skyrim only while Skyrim sorted first; it now picks Skyrim by id and drafts for Windows. Observed: it failed with Item not found 'Confirm these folders' once a game with no saves folder sorted first.The first tour card sat directly under the outlined row, over the rows below it, so the list the player came to use was hidden while the card showed. The card now also tries the spot under the last row, and a row of the list counts as an obstacle for that step. A window too small to hold the card elsewhere keeps the old spot, inside the window. Measuring the wide width and going back on every layout pass kept the layout from settling (Avalonia reported an infinite layout loop once a candidate failed), so the width now starts at the usual one for each new situation and only ever moves on to the wider one. Observed red before the change: TourViewTests.The_first_card_hides_no_other_row_of_the_profile_list failed for Sidebar and Library at 1040x660 ("the card 269, 201, 340, 176 covers a row of the list 259, 199, 758, 55").The line read "Going from X, to X" when the game version did not change, naming the same version twice. A version that stays is now left out when only the mods change ("Going from 212 mod files to no mods"), and a switch that changes neither says "Staying on X". Observed reds before the change: - LaunchDialogViewModelTests.A_version_that_does_not_change_is_not_named_twice_and_only_the_mods_that_change_are_said: expected "Going from 212 mod files to " but was "Going from 1.6.640 with 212 mod files, to " - LaunchDialogViewModelTests.A_version_and_mods_that_both_stay_are_said_once_as_staying and ..._with_no_mod_folders_to_count_...: expected "Staying on " but was "Going from ... to "The switch dialog now says only what changes ("Going from 2 mod files to ...") and names the target without the word "with". The journey test still expected the old sentence. Observed red (last full Windows gate): SwitchProfilesJourneyTests.Playing_the_other_profile_rewrites_both_folders_... failed at Assert.EndsWith with expected "with 2 mod files, to " against the dialog's "Going from 2 mod files to ". After the change the test passes.