0.9.3: switch to a profile or snapshot without starting the game #64
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!64
Loading…
Reference in a new issue
No description provided.
Delete branch "issue-30-switch-without-playing"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Adds a way to load a profile's or snapshot's files into the game's folders without starting the game, for working on mods in a mod manager, copying a save, a manual backup, or starting the game another way.
The Games row menu starts with "Switch to this profile", and History's cards, timeline entries and save rows offer "Switch to this snapshot". Both run the launch's own preparation (
ILaunchApi.SwitchAsync, aJobKind.Switchjob) and stop before the start: the same preview, the same guards for new changes, a running game and held files, Activity details and a cancel that asks first. Afterwards the profile reads "Loaded now" and no after-play dialog follows. The game stays claimed for the whole job, with its own refusal message (error.gameService.switching); a stopped switch recovers like an interrupted launch; Try again and the recovery buttons stay a switch; a finished switch notifies. The errors that said to play a profile first now offer the switch. Help, the tour and the snapshot answer mention it.Built test first (reds in the commit messages), reviewed, and reconciled with 0.9.2's per-operation error copy so a switch's held-file and disk-space errors read as a switch. D49 records the calls; architecture and the UI guide are updated. The Windows gate passed (9,556 tests, 0 failed, 28 listed skips).
Closes #30
error.launch.dirtyWorkingTree now reads the same for a play and a switch and names no button. Tests show that "Review the changes" and "Finish the switch" on a failed switch start another switch and not a launch. Observed red: LaunchFlowSwitchTests.A_switch_that_finds_new_changes_says_so_without_sending_the_player_to_Play... failed at Assert.Equal on the body ("Press Play to choose whether..."). The Finish the switch test passed first time; with re-entry forced to a play, both new tests and the cancel test failed.A switch holds the game, but the game is not running, so starting, switching again, discarding, deleting, editing folders, moving storage and clearing data now refuse with error.gameService.switching ("SavePoint is switching X's files right now...") when a switch holds it. A running game still gets the old messages. Observed red: LaunchSwitchOnlyTests.A_switch_waiting_for_the_game_keeps_it_taken... failed with Expected "error.gameService.switching" Actual "error.launch.alreadyRunning"; the contract story's new discard step failed with "fake: unexpected success" against "real: error error.gameService.switching" until the fake held the game for a switch the same way.