0.9.20: Steam check before launch, live change tracking, game editor cards and pickers, layout fixes #254
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!254
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-0920"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A game installed in a Steam library that runs its program now makes sure Steam is ready before anything is read or switched, and never starts the game through Steam, so Steam cannot update a version the player switched to (#243, D67). Its card offers Start Steam (the client alone, -silent), Play without Steam and Not now; the game's appmanifest is read, never written, before Steam starts, before the switch and before the program starts, and the launch is refused if Steam is updating or changed the build, before the switch when it can be. GOG and retail copies that only carry a Steam app id are not affected. After play, a snapshot is refused while the game still runs, with a short relaunch check and Choose again. Manifest update detection after play is #250; smaller follow-ups are in #251 and #253.
The profile table follows the shown game's folders as they change (#245, D68): watched off the UI thread, one read per burst (750 ms quiet, within 5 s, spaced by the last read's duration), quiet during jobs, play and while the window is in the background, and returning to the window reads only when something may have been missed. The game editor is a column of cards (Game, Saves, Mods, Artwork, More settings) with clear mods wording, per-question text and help links, glob-pattern rules stated as not regex (#242, D19, D7), and Choose files / Choose folders pickers for mod files inside the install folder (#247). The sidebar's games list scrolls alone and the library shelf wraps (#239, #237, D69); a new horizontal overflow audit covers every app state, including the editor and the new Steam cards.
Each change was implemented test-first, reviewed by an Opus code review (one critical: GOG copies forced to the Steam card, fixed) and a gap analysis; their findings and the gate regressions they caused were fixed on this branch.
Local gates on
bc260094: Windows gate passed (19099 tests, 0 failed, 75 listed skips); Linux gate on the VM passed (0 failed, 144 listed skips).Closes #237 #239 #242 #245 #247
The editor was one run of fields in two columns, with the optional ones mixed in. It is now one column of cards in the order a player fills them in: "The game" (name, install folder, how to start; Required), "Saves" (Recommended), "Mods" (Optional), Artwork (Optional), and the closed "More settings" card for rules, extra options, stop detection and the Steam app ID. Each card heading is a level 2 heading and says how much it matters. Mods: the folder outside the game folder ("Mods outside the game folder", with "Does my game keep mods outside its folder?") and the list of mod files inside it ("Mod files inside the game folder", with a "When do I need this?" that says when) now sit together in the Mods card. The mod files no longer hide in More settings. Rules: the answer names the real pattern syntax (the matcher is the gitignore-style exclude list, not regular expressions): * ** ? [abc], a leading / or trailing /, a leading ! and last match wins. A line under the lists says they are patterns, not regular expressions. Links: the two mods answers end with "More in How SavePoint works", which opens a new "Mods inside and outside the game folder" topic. The online-games and Steam app ID answers have no topic on the page, so they have no link. Observed reds before the change (assertion failures, not harness errors): - GameEditorGuidanceTests.The_mods_folder_question_says_which_games_need_one_and_the_mod_file_answer_says_when_to_fill_it_in: Expected "Does my game keep mods outside its folder?", Actual "Where do my mods live?" - GameEditorGuidanceTests.Both_rule_lists_tell_a_screen_reader_that_they_hold_patterns_and_not_regular_expressions: Sub-string "not regular expressions" not found - GameEditorGuidanceTests.More_settings_stays_closed_when_the_edited_game_only_names_mod_files: Expected False, Actual True - GameEditorGuidanceTests.The_list_of_mod_files_is_named_for_the_inside_of_the_game_folder: Expected "Mod files inside the game folder", Actual "Folders that hold mods" - GameEditorCardsViewTests (8 of 11): No Control named GameCard / ModsCard / AdvancedCard / GameCardHeading / RulesSyntaxText Mutation checks for the tests that passed first time: a MinWidth of 1200 on the game card makes the side-clipping test fail, and an unnamed icon button makes the audit test fail.Choose files... and Choose folders... sit beside Add a folder or file in the mod files list. Each opens the system picker (several items selectable) in the game's install folder; every picked item inside it becomes an entry written from the install folder with forward slashes, a folder as a folder entry, repeats skipped. Items outside it are not added and one line says how many were left out and why. Without an install folder both are off, with the reason on the line under the list and as the buttons' help text. Folders and files go through two new IDialogs members, so a view model never calls the storage provider. The chip row now inserts and removes single chips instead of redrawing, so the buttons keep keyboard focus after a pick. The header's buttons moved from a horizontal stack in an Auto column to a wrapping panel that sits under the title in a window narrower than 760 px, in the same order. Reds observed before the change: - GameEditorModFilePickTests (12 of 13): entries Actual [] for the pick of root files, a subfolder file and folders; the left-out line Actual "" ; the no-install reason Actual "". - StoragePickerOptionsTests.A_folder_pick_can_ask_for_several_folders and An_open_pick_can_ask_for_several_files: Expected True, Actual False. - AvaloniaDialogsTests.Multi_picks_answer_nothing_while_no_window_offers_a_storage_provider: failed against a placeholder answer. - GameEditorHeaderViewTests.Every_header_button_ends_inside_the_smallest_window: SaveButton ends at 647 (existing game) and 705 (new game), past the window's 640. - ChipListViewModelTests: the new AddValues and entry tests were red against stubs; the two that first passed (no rebuild of the row, add values) were mutation-checked: always redrawing the row fails Adding_values_slots_the_new_chips_in_before_the_add_chip_without_rebuilding_the_row, an AddValues that adds nothing fails the order and count test. - Passed on first run, mutation-checked: GameEditorModFilePickViewTests (always redrawing the row fails the focus test; dropping the buttons' help text fails the no-install test), GameEditorModFilePickTests.The_extra_buttons_are_named_for_what_they_pick (swapped name fails), and the wide-window case of GameEditorHeaderViewTests (a threshold of 5000 fails it). - AppStateAuditTests editor-new and editor-existing failed on the first button names ("shows 'Choose files...' but is named 'Choose mod files in the game folder'"), so the names now start with the visible text.Screen readers: each editor card header (Game, Saves, Mods, Artwork) is now one heading named with its tag ('Game, Required'); the drawn heading and tag are not read again. A TextBlock's peer ignores AutomationProperties.Name, so the name sits on the header grid (AccessibilityView=Content). More settings gets heading level 2 like the other cards. In the icon rail the hidden 'No games yet.' note is carried as the Add a game button's help text, only while compact and empty. Reds seen: A_screen_reader_hears_how_much_a_card_matters_as_part_of_its_heading ('Game, Required' expected, 'Game' actual), More_settings_is_a_heading_at_the_same_level_as_the_other_cards (2 expected, 0 actual), The_visible_tags_are_not_read_a_second_time (tag was a content element). Rail help text: with the HelpText binding removed the icon-rail test failed (Expected 'No games yet.', Actual 'Add a game' from the tooltip) and the widen test failed (Actual null); restored. Mod-file picks: naming another game folder clears the left-out line (Expected '', Actual '1 item was left out...'); a folder typed with backslashes is not added again when picked (Expected 'BepInEx', Actual 'Data/Mods').After-play save tests ended the session with "I'm done" while the stand-in game was still running. The running-game guard correctly refuses a snapshot then (sessionStillRunning), so each test now closes the game first, as a player's game would be closed: ModsLaunchTests.Saving_after_play_writes_a_point_in_all_three_folders, LaunchHeldFileTests (both after-play tests, InUse and Unreadable), LaunchActionLogTests.A_save_that_skipped_a_folder_logs_which_folder_and_why and the PlayAsync helper of LaunchRunTimeOutputTests (its two save tests failed on Linux). The guard itself is unchanged. The editor opened scrolled in the smallest window: the launch choice list scrolled its selected item into view, and now that the cards put that list just below the fold it moved the form by 26 px (86 px in the Library layout). The list no longer scrolls to its selection, as the Settings choice lists already do. The scroll check now names the scroll area and its offset. GameEditorFormTests and GameEditorModsFolderTests asserted help copy the card regrouping reworded; they assert the new copy. Reds observed on the merged tip: Assert.True() Failure (Expected True, Actual False) at each CompleteSessionAsync call above; JobPillPlacementTests editor, smallest window: "a scroll area did not start at the top (FormScroll at 26)" and "at 86"; GameEditorFormTests: Strings differ at pos 129 ("Use * for any name" vs "Rules are patterns"); GameEditorModsFolderTests: Expected "Where do my mods live?" Actual "Does my game keep mods outside its folder?".Red observed (with the reporter made to deliver the last name in the final report, as the Windows CI run did): CaptureProgressTests.A_later_capture_counts_only_the_files_that_changed failed at the progress.Last equality with 'Expected: FileProgress { ... NewPaths = , ...} Actual: FileProgress { ... NewPaths = <>z__ReadOnlyArray[String] ...}'. Which report carries the name depends on whether the store poll saw the last byte before the add finished, so the test now compares the numbers with NewPaths set aside and asserts the names once over every report.