0.9.16: finish a switch that stopped part way, help topics, and screen-reader choices #192
No reviewers
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint!192
Loading…
Reference in a new issue
No description provided.
Delete branch "integration-0916"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #161 and #168.
#168: after SavePoint is killed mid-checkout, Switch again refused with unsaved changes. The finish now writes the target's copy of the files the stopped switch was changing (skipping those that already hold it, checked by size then blob hash), then moves the folder to the target. Any other change, an edited file the switch removes, or a folder the review could not check holds the finish back before anything is written and offers only Discard, with copy saying why. The launch dialog counts the files finishing will replace and names them for the saves folder. Case-only renames finish on Windows and macOS. D31.6 records it.
#161: How SavePoint works gains three topics (how the game starts, files to leave out, cloud saves), linked from the editor's question buttons; Back restores the editor's scroll position and focus. Every single-choice list is a ChoiceListBox: a named group of radio buttons with selection and toggle state for UIA, VoiceOver and Orca, arrow keys that move and wrap, and a lint test against plain ListBoxes used that way.
Both were implemented test-first and reviewed by a separate reviewer (#168 twice), and the branch was checked against the coding standards from PR 189 (fixes in
13bd91d; LaunchRig setup cost is #190, the list separator #191). The local Windows gate passed on this branch. Version 0.9.16.The launch choice ("How to start the game") and the other choices of one among a few (theme, layout cards, accent swatches, the Sidebar/Library switch, the History view switch, the Activity scope switch, and the cards after playing) were plain lists to assistive technology. ChoiceListBox is a ListBox whose automation peer is a named Group and whose options are RadioButton peers that keep the selection pattern, so each option is announced with its selected state. Its arrow keys also move the choice: Down and Right go forward, Up and Left go back, wrapping at the ends, flipped for right-to-left. The list's own handling did nothing for options in a UniformGrid, so the launch choice could not be changed with the arrow keys. Observed reds (before the code): - ChoiceListSemanticsTests.A_choice_of_one_is_a_named_group_of_radio_buttons, 8 cases: Assert.Equal(Group, List) for each list. - ChoiceListSemanticsTests launch choice with Down: expected selected index 1, actual 0 (focus and selection did not move). - ChoiceListSemanticsTests.No_choice_of_one_in_the_app_is_left_as_a_plain_list: five views still declared a plain ListBox for a choice. - Mutation checks: an option peer without the selection pattern makes the option-state tests fail (0 options found); Right mapped to no step makes the arrow-key tests fail for the launch choice, the layout cards and the theme selector.On Linux, git refuses the checkout that ends a stopped switch when the target's file already stands where HEAD has a folder: it takes the file for an untracked one in the way of removing the folder's files. The finish wrote the file with a path checkout first, so the refusal came after the index already said the file was there, and the switch could never be finished. Windows git answers this differently, which is why only the Linux gate failed. The finish now removes such a file (a stopped switch's own write) and lets the checkout write it from the target, as a switch that never stopped does. The removal is a guarded step ("remove-standing") like the other deletions the engine makes itself. Red, observed on Ubuntu 26.04 (ext4, git 2.53) before the change: FinishSwitchTests.A_killed_switch_that_stood_a_folder_where_a_file_was_is_finished_too and the new A_killed_switch_that_finished_the_file_where_a_folder_was_is_finished_too both threw DirtyWorkingTreeException from RunCheckoutAsync. Both pass on the VM after the change. The new folder-recheck test was mutation checked by dropping the recheck call (red), then restored.