Cut repeated and over-explained copy across the app #126

Merged
ethan-hann merged 11 commits from integration-123 into main 2026-10-25 06:52:51 -05:00
Owner

Players found much of the copy saying the same idea twice in different words, or explaining simple things at length. Every catalog file was gone through screen by screen.

  • Each fact is said once, in the place it belongs, and only named elsewhere: the full Recently removed rule lives in the help page's Recently removed section; keeping a new snapshot as the safe choice, SavePoint showing what changes first, and what a profile and a snapshot are each live in one help section.
  • Tour steps are one sentence each, and each What's this? answer only answers its question.
  • Error bodies no longer restate their titles; each says what happened and what to do, once. A file another program holds is described the same way everywhere.
  • Helper lines that only restated their label are gone (the profile-name helper in the new-profile wizard and the accent hint in Settings), with their view code and keys.
  • Every safety fact stays: what is deleted for good, what goes to Recently removed, what is left unchanged.
  • The UI guide's copy notes now state the say-it-once rule.

Roughly: help prose down about a third; launch, error and validation copy down 16%; the screens, editor and settings down 13% (much of what is left there is titles, labels and plural markup). Pinned test strings were updated with the copy. Closes #123.

Players found much of the copy saying the same idea twice in different words, or explaining simple things at length. Every catalog file was gone through screen by screen. - Each fact is said once, in the place it belongs, and only named elsewhere: the full Recently removed rule lives in the help page's Recently removed section; keeping a new snapshot as the safe choice, SavePoint showing what changes first, and what a profile and a snapshot are each live in one help section. - Tour steps are one sentence each, and each What's this? answer only answers its question. - Error bodies no longer restate their titles; each says what happened and what to do, once. A file another program holds is described the same way everywhere. - Helper lines that only restated their label are gone (the profile-name helper in the new-profile wizard and the accent hint in Settings), with their view code and keys. - Every safety fact stays: what is deleted for good, what goes to Recently removed, what is left unchanged. - The UI guide's copy notes now state the say-it-once rule. Roughly: help prose down about a third; launch, error and validation copy down 16%; the screens, editor and settings down 13% (much of what is left there is titles, labels and plural markup). Pinned test strings were updated with the copy. Closes #123.
Each help explanation now says its idea once; restated causes, remedies and
'until you next free up space' clauses are merged. Tests that pin the exact
strings follow.

Observed reds after the copy edits (before updating pins):
HowItWorksViewModelTests.The_basics_teach_game_profile_and_snapshot... (Strings differ),
TourViewModelTests.Each_step_says_what_the_control_it_points_at_does (Strings differ),
StartupViewModelTests.Each_kind_of_file_gets_its_own_title... (Strings differ),
ExitGuardTests.A_free_up_that_has_deleted_snapshots_asks_first... (Assert.Contains failure).
The Recently removed rule, the safe-choice note, the show-first rule and the
profile and snapshot definitions now live in one string each; What's this?
answers and tour steps answer only their question. Tests that pin the strings
follow.

Observed reds after the copy edits (before updating pins):
ContextualHelpViewModelTests.Which_should_I_pick... (Strings differ),
HowItWorksViewModelTests.Activity_is_a_topic_of_its_own... (Not found: taking snapshots),
TourViewModelTests.Each_step_says_what_the_control_it_points_at_does (Strings differ),
StartupViewModelTests.Each_kind_of_file_gets_its_own_title... (Strings differ).
Say each fact once: Recently removed is explained in the confirm dialogs and only named on the cards, error bodies no longer restate their titles, and filler is dropped. About 16 percent fewer words across launch.json, errors.json and validation.json. Keys and ICU placeholders are unchanged.

Observed reds (assertion failures on the old tests after the catalog edit): LaunchFlowSwitchTests subtitle, PostPlayDialogViewModelTests body/subtitles, ErrorCardViewModelTests clash text, GameEditorErrorTests start-file text, and others; each expectation was updated to the new copy.
Say each fact once: helper and description text that restated its title,
label or button is shortened or cut, long confirmations lose the sentence
that repeated the title, and the editor's anti-cheat note now matches the
start screen's. Safety facts (what is deleted, what is kept, what happens
to saves) stay. The strings are pinned by existing tests, which now assert
the new wording.

Observed reds (stale pins failing on assertion before the pins were
updated): GameEditorViewTests.Each_rule_list_names_its_add_button_and_field_and_carries_its_help_text
(Assert.Contains sub-string not found),
StorageSectionViewModelTests.The_optimize_row_never_says_free_up_space_runs_by_itself_and_says_the_automatic_cleanups_keep_recently_removed
(sub-string not found), GamesScreenActionsTests first-snapshot and delete
confirmation messages (Expected/Actual text differed).
Remove two helpers that only restated their label (the new profile name
helper and the accent color hint), with their view lines, the view model
property and the catalog keys. Shorten the shared error-card bodies (held
file, not enough disk space), the job log lines and stop notes, the
consent texts, and a few settings and editor descriptions. Safety facts
stay. Tests that pinned the old wording now assert the new wording, and
the tests of the removed helpers are gone.

Observed reds before the pins were updated: JobLineFormatterTests
Every_byte_count_of_a_step_is_shown_as_a_size (Expected "Still copying
Data/big.pak..." Actual "Copying Data/big.pak: 1.5 GB of 4.5 GB."),
UiFormatterTests The_out_of_space_message_says_which_drive_and_how_much_to_free
(Expected "There's not enough free disk space..." Actual "Not enough free
disk space..."), ActivityScreenViewModelTests
A_cancel_the_job_ignores_says_so_instead_of_leaving_the_row_looking_stuck
(Expected "That job couldn't be stopped just now..." Actual "The job
couldn't be stopped...").
# Conflicts:
#	tests/Savepoint.App.Tests/Features/Launch/LaunchFlowSessionTests.cs
Merge branch 'main' into integration-123
All checks were successful
Gate / linux (pull_request) Successful in 12m38s
Gate / windows (pull_request) Successful in 36m4s
Wiki / publish (push) Successful in 44s
Gate / linux (push) Successful in 12m5s
Gate / windows (push) Successful in 38m9s
0b02089f1d
Sign in to join this conversation.
No reviewers
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint!126
No description provided.