Snapshot space check follow-ups after leaving out stored content #240

Closed
opened 2026-10-27 13:16:42 -05:00 by ethan-hann · 1 comment
Owner

Smaller gaps left after the snapshot space check learned to leave out content already in the store (#170, D16):

  • When several folders save together, a folder that passes its own check on raw size reports that raw figure to the shared room gate (CaptureRoomGate), and each folder reports only once, so the combined check can refuse where the reduced total would have fit. Let a folder report a second, reduced figure, or read files whenever the combined check would refuse.
  • Files git streams (128 MiB and over) always count in full, so the largest assets gain nothing. A cheap exact signal for them would need stat data stored per snapshot.
  • The capture progress bar's byte total still uses full file sizes.
Smaller gaps left after the snapshot space check learned to leave out content already in the store (#170, D16): - When several folders save together, a folder that passes its own check on raw size reports that raw figure to the shared room gate (CaptureRoomGate), and each folder reports only once, so the combined check can refuse where the reduced total would have fit. Let a folder report a second, reduced figure, or read files whenever the combined check would refuse. - Files git streams (128 MiB and over) always count in full, so the largest assets gain nothing. A cheap exact signal for them would need stat data stored per snapshot. - The capture progress bar's byte total still uses full file sizes.
ethan-hann added this to the Later milestone 2026-10-27 13:16:42 -05:00
Author
Owner

Shipped in SavePoint 0.9.22 (PR #274). The streamed-file item (128 MiB and over) is left as the issue says: an exact signal needs stat data stored per snapshot. The progress total uses the reduced figure when the space check already found it (D16).

Shipped in [SavePoint 0.9.22](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.22) (PR #274). The streamed-file item (128 MiB and over) is left as the issue says: an exact signal needs stat data stored per snapshot. The progress total uses the reduced figure when the space check already found it (D16).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#240
No description provided.