Do not count content already in the store when estimating a snapshot's size #170
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#170
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The snapshot space check sums the raw size of every new or changed file. A file whose content is already stored (switching back to a known version, a reverted file) adds nothing to the store, so a nearly full drive can be refused for a snapshot that would fit. Hashing is too slow for a pre-check; a cheaper signal may be the index stat match against known blobs, or treating files whose size and name match a stored entry as already stored.
Fixed in 0.9.19 (PR 252): https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.19