Replace unexplained fixed sleeps in tests with condition waits #186
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#186
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
.agents/coding-standards/tests-naming-and-structure.mdsays a test waits on a condition with a deadline (such asUiWait.UntilAsync), and keeps a fixed delay only with a comment that names an outside clock. List them with:Known cases with no stated clock:
CaptureBytesTests(Thread.Sleep(500)) andProfilesCaptureTests(Thread.Sleep(300)). Also checkConsentMarkerTests(Thread.Sleep(holdFor)),AvaloniaCrashPresenterTests, and the retry sleeps inBackendWorkspace,GitWorkspace, andJourneyRig; a retry loop with a deadline is fine, and needs only a comment if the reason is not plain.Shipped in 0.9.17 (PR 227).