A switch removes an empty folder the game shipped with #66

Closed
opened 2026-10-24 04:09:28 -05:00 by ethan-hann · 0 comments
Owner

Found on a real install (Cyberpunk 2077 from GOG, .tools/reviews/dogfood-cyberpunk.md). The install ships an empty archive\pc\mod folder, which mod tools expect. After a profile that put a file in it and a switch back to the vanilla profile, the folder was gone: git does not track empty folders, so the switch pruned it when the file left. Every one of the 5,068 files matched afterwards, so only the empty folder was lost.

A snapshot should bring back the folders it was taken with, empty ones included, and a switch should not remove an empty folder that the target snapshot had. Done when a snapshot taken with an empty folder restores it after switching through a profile that filled it and back, tested against the real backend, with the call recorded in docs/decisions.md.

Found on a real install (Cyberpunk 2077 from GOG, `.tools/reviews/dogfood-cyberpunk.md`). The install ships an empty `archive\pc\mod` folder, which mod tools expect. After a profile that put a file in it and a switch back to the vanilla profile, the folder was gone: git does not track empty folders, so the switch pruned it when the file left. Every one of the 5,068 files matched afterwards, so only the empty folder was lost. A snapshot should bring back the folders it was taken with, empty ones included, and a switch should not remove an empty folder that the target snapshot had. Done when a snapshot taken with an empty folder restores it after switching through a profile that filled it and back, tested against the real backend, with the call recorded in docs/decisions.md.
ethan-hann added this to the 1.0 milestone 2026-10-24 04:09:28 -05:00
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#66
No description provided.