Steam app id detection disagrees with what Steam writes #39
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#39
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
An audit of the installed Steam games on one PC (174 installed, 25 with
steam_appid.txtin the install folder) found:Trim()keeps the NUL, so the detector rejects them and falls back to the manifest (SteamAppIdDetector.cs:57). A game copied outside a Steam library then gets no id.Binaries/Win64), which is never checked.SteamAppIdDetector.cs:28), both get no artwork.Wanted: inside a Steam library, the manifest's id wins and the file is the fallback; the file parser accepts trailing NUL bytes and whitespace (digits only, nothing else); the usual binary subfolders are checked. The image servers may also answer with
image/png(2 of 58 sampled cached tall images are PNG data); accept PNG and WebP content types and let the image check judge the bytes.