Let a save from one profile be used in another profile of the same game #271

Open
opened 2026-10-28 23:11:14 -05:00 by ethan-hann · 1 comment
Owner

Found in a real test on 0.9.21 with No Man's Sky, the day the 7.10 FORSAKEN update came out. Two profiles: "Modded NMS - Cosmos 7.06" (build 180836) and "Modded NMS - FORSAKEN 7.10" (build 183791), same 1,163 mod files.

What happened. Loading the saves on 7.10 put the player straight into a death loop (a game problem, not SavePoint's). To recover, they switched to the Cosmos 7.06 profile, loaded the known-good save, flew the ship to a safe spot, saved, and took a snapshot ("Recovered save after death loop from version 7.10"). Then they wanted to play that recovered save on FORSAKEN 7.10. SavePoint would only offer FORSAKEN's own saves (the bad one). The only way across is by hand: go back to Cosmos without playing, copy the saves folder out, go back to FORSAKEN, paste the files in, take a snapshot.

Why it matters. A player thinks of their save as their progress and expects it to follow them from one game version to the next; profiles bundle version, mods and saves, so a save is stuck in the profile it was taken in. "Keep my progress, change the game version" is the most common thing a player wants after an update, and today SavePoint makes it harder than doing it by hand. In the tester's words: "Now that I am trying to actually use SavePoint it doesn't intuitively work the way I thought it would."

What to decide and build (design first, with a numbered decision in docs/decisions.md):

  • A way to use a save snapshot from another profile of the same game, for example "Use this save with..." on a save in History, and other profiles' saves offered (clearly labelled) in the check before playing.

  • What happens to the target profile's current saves (they must stay in History, nothing lost), and how the result is recorded (a new save snapshot of the target profile that says where it came from).

  • A plain warning when the save comes from a different game version (newer to older usually fails in games; older to newer usually upgrades), without blocking it.

  • Whether profiles should be able to share one line of saves across game versions (one playthrough, several versions), which may be what most players expect.

  • Interaction with cloud saves (D-entry on Steam/Galaxy sync), leave-out rules, and profiles made from another profile (which already offer the saves they started with).

Related: the snapshot titles and the Version column show the Steam build number (180836, 183791) rather than the version players know (7.06, 7.10).

Found in a real test on 0.9.21 with No Man's Sky, the day the 7.10 FORSAKEN update came out. Two profiles: "Modded NMS - Cosmos 7.06" (build 180836) and "Modded NMS - FORSAKEN 7.10" (build 183791), same 1,163 mod files. **What happened.** Loading the saves on 7.10 put the player straight into a death loop (a game problem, not SavePoint's). To recover, they switched to the Cosmos 7.06 profile, loaded the known-good save, flew the ship to a safe spot, saved, and took a snapshot ("Recovered save after death loop from version 7.10"). Then they wanted to play that recovered save on FORSAKEN 7.10. SavePoint would only offer FORSAKEN's own saves (the bad one). The only way across is by hand: go back to Cosmos without playing, copy the saves folder out, go back to FORSAKEN, paste the files in, take a snapshot. **Why it matters.** A player thinks of their save as their progress and expects it to follow them from one game version to the next; profiles bundle version, mods and saves, so a save is stuck in the profile it was taken in. "Keep my progress, change the game version" is the most common thing a player wants after an update, and today SavePoint makes it harder than doing it by hand. In the tester's words: "Now that I am trying to actually use SavePoint it doesn't intuitively work the way I thought it would." **What to decide and build** (design first, with a numbered decision in docs/decisions.md): - A way to use a save snapshot from another profile of the same game, for example "Use this save with..." on a save in History, and other profiles' saves offered (clearly labelled) in the check before playing. - What happens to the target profile's current saves (they must stay in History, nothing lost), and how the result is recorded (a new save snapshot of the target profile that says where it came from). - A plain warning when the save comes from a different game version (newer to older usually fails in games; older to newer usually upgrades), without blocking it. - Whether profiles should be able to share one line of saves across game versions (one playthrough, several versions), which may be what most players expect. - Interaction with cloud saves (D-entry on Steam/Galaxy sync), leave-out rules, and profiles made from another profile (which already offer the saves they started with). Related: the snapshot titles and the Version column show the Steam build number (180836, 183791) rather than the version players know (7.06, 7.10).
ethan-hann added this to the 1.0 milestone 2026-10-28 23:11:14 -05:00
Author
Owner

Design proposal (research only, nothing built)

What the code does today

A game has one git store per folder (install, mods, saves). A profile is one branch, profile/<id>, in each store (Profile.BranchName). A save snapshot is a commit on the saves store's profile branch with a Savepoint-Capture trailer; History groups the folders' commits by that id, and the first profile in catalog order that holds the commit owns it (HistoryReader). The check before playing lists only the target profile's lineage (LaunchPreview.AvailableSaves, built by TargetResolver.SavesOf), and ResolveBranchAsync throws PointNotFound for any save id outside that lineage. Duplicate starts the copy's saves empty (CreateEmptyBranchAsync).

The storage fact that decides this: every profile's saves share one object store, so putting another profile's save tree on a branch is one commit-tree plus one ref update, no bytes copied. GitEngine.CreateBranchAsCopyAsync already writes a commit with a chosen tree, trailers and parents. What is expensive is changing what a branch means (B and C below), because D14's replace rule, D15 ownership, D17 delete warnings, D44.4 Recently removed and D65 all read refs/heads/profile/*.

Prior art: MO2 gives each profile its own saves folder and users move files by hand between profiles (https://stepmodifications.org/forum/topic/17567-problem-transferring-saves-to-profiles/), which is exactly the tester's complaint. Ludusavi keeps per-backup comments and locks but no per-version lines (https://github.com/mtkennerly/ludusavi). For No Man's Sky, older saves load on newer builds while newer saves on older builds fail (https://steamcommunity.com/app/275850/discussions/0/601901942630808909), which fits the warning below.

Option A: saves stay per profile, plus "Use this save with..."

Player flow: on any save in History (or a row in the launch picker), "Use this save with..." lists the game's other profiles. The confirmation says: "Your current saves on 'FORSAKEN 7.10' stay in History as ''." Buttons: "Add and play", "Add without playing". The check before playing also gets a second group, "Saves from other profiles", each row labelled " - ".

Storage: a new save-only commit on the target's saves branch whose tree is the source commit's tree, parent the target's tip, a new capture id, plus a new trailer Savepoint-Save-From: <source capture id>. Name: "From Cosmos 7.06: Recovered run". Then the normal switch to that save. Nothing is rewritten, so the target's old saves remain the previous points.

Risks: none to data (append only). Cloud (D56.2): Steam sees the imported files as changed and uploads them at exit, which is what the player wants; a second PC gets a Cloud Conflict, never a silent loss. A newer-to-older import may fail to load or corrupt in game; the source snapshot is untouched, so Go back recovers it. Leave-out rules: the tree holds only snapshotted files; files the rules cover stay on disk as they are (D65.4). Profiles made from another: the wizard's "start saves empty" box gains a sibling, "start with a save from...", using the same operation. Migration: none; older versions read the trailer as an ordinary save.

Build: Core GitEngine.CommitTreeOnBranchAsync (mirrors CreateBranchAsCopyAsync), IProfilesApi.UseSaveAsync(gameId, targetProfileId, sourceSaveId, name) under the game lock, HistoryPoint.FromProfileName/FromPointId, LaunchPreview.OtherProfileSaves, the version warning, catalog strings, History and launch dialog UI, tests, guide and screenshots. About 2 to 3 implementer-days, one batch.

Option B: one save line per game, per-profile opt-out

Profiles keep version and mods; saves become one game-wide branch every profile loads unless it opts out ("Keep its own saves"). Matches the No Man's Sky case ("one playthrough, several versions") but breaks the other common case: Skyrim or Bannerlord profiles with different mod lists whose saves are not interchangeable, and D65's "start with no saves". Every profile's tip becomes the newest save regardless of version, so a 7.10 save silently becomes 7.06's next load: the death loop, reversed. Storage: Profile gains a saves-line id; ownership, D14 replace, D17, Recently removed and Bring back all need a second rule for a branch no profile owns. The catalog change is not additive like D61, so 0.9.x cannot read it. Cloud: one line crossing versions uploads older content repeatedly (D56.2). About 2 to 3 weeks and five decisions reopened.

Option C: named playthroughs a profile points at

Saves live in named lines (saves/<id>), a profile points at one, several profiles may share one, and a profile can start a new line. This is B done explicitly, and it is the right long-term model: "Playthrough: Main run" on both No Man's Sky profiles is what the tester expected. It costs everything B costs plus a playthrough list, rename, and a picker in the wizard and launch dialog. About 3 to 4 weeks. Migration: each existing profile gets a line of its own, so nothing changes until the player shares one.

Recommendation

Build A for 1.0. It fixes the reported flow, loses nothing, needs no migration, and its trailer and "Use with" verb are the ones C would keep, so C later is a storage change, not a UI rewrite. Record it as the next decision entry: "Saves stay with their profile; a save is used in another profile by adding it there as a new snapshot that names its source."

Version warning (never blocks): compare the source point's install version to the target's current version, using VersionOverride when set. Newer source: "This save was made on , a newer version than runs. Older versions often can't load newer saves." Older source: " will usually update this save when it loads; after that it may not load on any more." Equal or unknown: nothing. On the related Version column point, the warning and the import name should prefer the player's typed version (Profile.VersionOverride, D13.6) over the build number, and the wizard could ask for it when D54 reads only a build.

Open questions before building

  1. A now, or straight to C?
  2. Does using a save always switch to it, or may "Add without playing" exist?
  3. Should the launch picker show other profiles' saves by default, or behind "Show saves from other profiles"?
  4. Default name: "From : " or the source name unchanged?
  5. Should Duplicate and the wizard offer "start with a save from..."?
  6. Warning only, or also a question button ("What happens to a save on another version?") in help.json?
  7. Should the Version column prefer the typed version over the build number (its own issue)?
## Design proposal (research only, nothing built) ### What the code does today A game has one git store per folder (install, mods, saves). A profile is one branch, `profile/<id>`, in each store (`Profile.BranchName`). A save snapshot is a commit on the saves store's profile branch with a `Savepoint-Capture` trailer; History groups the folders' commits by that id, and the first profile in catalog order that holds the commit owns it (`HistoryReader`). The check before playing lists only the target profile's lineage (`LaunchPreview.AvailableSaves`, built by `TargetResolver.SavesOf`), and `ResolveBranchAsync` throws `PointNotFound` for any save id outside that lineage. Duplicate starts the copy's saves empty (`CreateEmptyBranchAsync`). The storage fact that decides this: every profile's saves share one object store, so putting another profile's save tree on a branch is one `commit-tree` plus one ref update, no bytes copied. `GitEngine.CreateBranchAsCopyAsync` already writes a commit with a chosen tree, trailers and parents. What is expensive is changing what a branch means (B and C below), because D14's replace rule, D15 ownership, D17 delete warnings, D44.4 Recently removed and D65 all read `refs/heads/profile/*`. Prior art: MO2 gives each profile its own saves folder and users move files by hand between profiles (https://stepmodifications.org/forum/topic/17567-problem-transferring-saves-to-profiles/), which is exactly the tester's complaint. Ludusavi keeps per-backup comments and locks but no per-version lines (https://github.com/mtkennerly/ludusavi). For No Man's Sky, older saves load on newer builds while newer saves on older builds fail (https://steamcommunity.com/app/275850/discussions/0/601901942630808909), which fits the warning below. ### Option A: saves stay per profile, plus "Use this save with..." Player flow: on any save in History (or a row in the launch picker), "Use this save with..." lists the game's other profiles. The confirmation says: "Your current saves on 'FORSAKEN 7.10' stay in History as '<newest save name>'." Buttons: "Add and play", "Add without playing". The check before playing also gets a second group, "Saves from other profiles", each row labelled "<profile> - <version>". Storage: a new save-only commit on the target's saves branch whose tree is the source commit's tree, parent the target's tip, a new capture id, plus a new trailer `Savepoint-Save-From: <source capture id>`. Name: "From Cosmos 7.06: Recovered run". Then the normal switch to that save. Nothing is rewritten, so the target's old saves remain the previous points. Risks: none to data (append only). Cloud (D56.2): Steam sees the imported files as changed and uploads them at exit, which is what the player wants; a second PC gets a Cloud Conflict, never a silent loss. A newer-to-older import may fail to load or corrupt in game; the source snapshot is untouched, so Go back recovers it. Leave-out rules: the tree holds only snapshotted files; files the rules cover stay on disk as they are (D65.4). Profiles made from another: the wizard's "start saves empty" box gains a sibling, "start with a save from...", using the same operation. Migration: none; older versions read the trailer as an ordinary save. Build: Core `GitEngine.CommitTreeOnBranchAsync` (mirrors `CreateBranchAsCopyAsync`), `IProfilesApi.UseSaveAsync(gameId, targetProfileId, sourceSaveId, name)` under the game lock, `HistoryPoint.FromProfileName`/`FromPointId`, `LaunchPreview.OtherProfileSaves`, the version warning, catalog strings, History and launch dialog UI, tests, guide and screenshots. About 2 to 3 implementer-days, one batch. ### Option B: one save line per game, per-profile opt-out Profiles keep version and mods; saves become one game-wide branch every profile loads unless it opts out ("Keep its own saves"). Matches the No Man's Sky case ("one playthrough, several versions") but breaks the other common case: Skyrim or Bannerlord profiles with different mod lists whose saves are not interchangeable, and D65's "start with no saves". Every profile's tip becomes the newest save regardless of version, so a 7.10 save silently becomes 7.06's next load: the death loop, reversed. Storage: `Profile` gains a saves-line id; ownership, D14 replace, D17, Recently removed and Bring back all need a second rule for a branch no profile owns. The catalog change is not additive like D61, so 0.9.x cannot read it. Cloud: one line crossing versions uploads older content repeatedly (D56.2). About 2 to 3 weeks and five decisions reopened. ### Option C: named playthroughs a profile points at Saves live in named lines (`saves/<id>`), a profile points at one, several profiles may share one, and a profile can start a new line. This is B done explicitly, and it is the right long-term model: "Playthrough: Main run" on both No Man's Sky profiles is what the tester expected. It costs everything B costs plus a playthrough list, rename, and a picker in the wizard and launch dialog. About 3 to 4 weeks. Migration: each existing profile gets a line of its own, so nothing changes until the player shares one. ### Recommendation Build A for 1.0. It fixes the reported flow, loses nothing, needs no migration, and its trailer and "Use with" verb are the ones C would keep, so C later is a storage change, not a UI rewrite. Record it as the next decision entry: "Saves stay with their profile; a save is used in another profile by adding it there as a new snapshot that names its source." Version warning (never blocks): compare the source point's install version to the target's current version, using `VersionOverride` when set. Newer source: "This save was made on <v>, a newer version than <profile> runs. Older versions often can't load newer saves." Older source: "<profile> will usually update this save when it loads; after that it may not load on <old v> any more." Equal or unknown: nothing. On the related Version column point, the warning and the import name should prefer the player's typed version (`Profile.VersionOverride`, D13.6) over the build number, and the wizard could ask for it when D54 reads only a build. ### Open questions before building 1. A now, or straight to C? 2. Does using a save always switch to it, or may "Add without playing" exist? 3. Should the launch picker show other profiles' saves by default, or behind "Show saves from other profiles"? 4. Default name: "From <profile>: <save>" or the source name unchanged? 5. Should Duplicate and the wizard offer "start with a save from..."? 6. Warning only, or also a question button ("What happens to a save on another version?") in help.json? 7. Should the Version column prefer the typed version over the build number (its own issue)?
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#271
No description provided.