Check that the new profile preview ends loading only after its data is in place #268
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#268
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The Games screen dropped its loading flag before the rows had their stats, so a test that waited for loading to end could read rows still showing a dash (#266, fixed in 0.9.21: the flag now drops last).
The same wait-on-the-flag-then-read pattern is used for the new profile wizard's preview: tests/Savepoint.App.Tests/Journeys/JourneyRig.cs (~line 211) and FileInUseJourneyTests.cs (~line 69) wait on
!wizard.Preview.IsLoadingand then read what the preview loaded. Nobody has checked whether NewProfileWizard's preview sets IsLoading false only after its data is in place.Check the preview's load order test-first (record the preview's state at the moment IsLoading turns false, as GamesScreenViewModelTests does), fix the order if it is wrong, and look for any other view model whose loading flag drops before its result is applied.
Shipped in SavePoint 0.9.22 (PR #274). The wizard preview's order was already right (now pinned by tests); the game picker dropped its loading flag before its list was built and is fixed.