Check that the new profile preview ends loading only after its data is in place #268

Closed
opened 2026-10-28 19:04:56 -05:00 by ethan-hann · 1 comment
Owner

The Games screen dropped its loading flag before the rows had their stats, so a test that waited for loading to end could read rows still showing a dash (#266, fixed in 0.9.21: the flag now drops last).

The same wait-on-the-flag-then-read pattern is used for the new profile wizard's preview: tests/Savepoint.App.Tests/Journeys/JourneyRig.cs (~line 211) and FileInUseJourneyTests.cs (~line 69) wait on !wizard.Preview.IsLoading and then read what the preview loaded. Nobody has checked whether NewProfileWizard's preview sets IsLoading false only after its data is in place.

Check the preview's load order test-first (record the preview's state at the moment IsLoading turns false, as GamesScreenViewModelTests does), fix the order if it is wrong, and look for any other view model whose loading flag drops before its result is applied.

The Games screen dropped its loading flag before the rows had their stats, so a test that waited for loading to end could read rows still showing a dash (#266, fixed in 0.9.21: the flag now drops last). The same wait-on-the-flag-then-read pattern is used for the new profile wizard's preview: tests/Savepoint.App.Tests/Journeys/JourneyRig.cs (~line 211) and FileInUseJourneyTests.cs (~line 69) wait on `!wizard.Preview.IsLoading` and then read what the preview loaded. Nobody has checked whether NewProfileWizard's preview sets IsLoading false only after its data is in place. Check the preview's load order test-first (record the preview's state at the moment IsLoading turns false, as GamesScreenViewModelTests does), fix the order if it is wrong, and look for any other view model whose loading flag drops before its result is applied.
ethan-hann added this to the Code Cleanup milestone 2026-10-28 19:04:56 -05:00
Author
Owner

Shipped in SavePoint 0.9.22 (PR #274). The wizard preview's order was already right (now pinned by tests); the game picker dropped its loading flag before its list was built and is fixed.

Shipped in [SavePoint 0.9.22](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.22) (PR #274). The wizard preview's order was already right (now pinned by tests); the game picker dropped its loading flag before its list was built and is fixed.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#268
No description provided.