Remove tests that only check a fake stores or echoes its input #261

Closed
opened 2026-10-27 21:26:22 -05:00 by ethan-hann · 1 comment
Owner

FakeCallLogTests and the fake tests that only check a fake stores or echoes what it was given test the test tooling, not the app. Keep tests only where a fake has real logic other tests rely on (and then prefer a contract step against the real backend); delete the rest. Also name a proof test for each shared contract-story step that has none. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)

FakeCallLogTests and the fake tests that only check a fake stores or echoes what it was given test the test tooling, not the app. Keep tests only where a fake has real logic other tests rely on (and then prefer a contract step against the real backend); delete the rest. Also name a proof test for each shared contract-story step that has none. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)
ethan-hann added this to the Code Cleanup milestone 2026-10-27 21:26:22 -05:00
Author
Owner

Shipped in SavePoint 0.9.22 (PR #274).

Shipped in [SavePoint 0.9.22](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.22) (PR #274).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#261
No description provided.