Let ComposedApp take a dispatcher and cover the editor, shell and library off the UI thread #260

Closed
opened 2026-10-27 21:26:20 -05:00 by ethan-hann · 1 comment
Owner

ComposedApp builds the app with the instant dispatcher and has no dispatcher parameter, and the dispatcher parameters on EditorRig, HistoryRig, SettingsRig and ShellViewHarness have no caller, so no off-thread test covers the editor, shell or library. Add the parameter, write #246-shaped tests (events delivered off the UI thread, a list changed during selection) for those screens, and make the off-thread tests able to tell a handler that posts from one that writes off the UI thread. Give FakeBackend.WhenEventsDeliveredAsync a deadline. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)

ComposedApp builds the app with the instant dispatcher and has no dispatcher parameter, and the dispatcher parameters on EditorRig, HistoryRig, SettingsRig and ShellViewHarness have no caller, so no off-thread test covers the editor, shell or library. Add the parameter, write #246-shaped tests (events delivered off the UI thread, a list changed during selection) for those screens, and make the off-thread tests able to tell a handler that posts from one that writes off the UI thread. Give FakeBackend.WhenEventsDeliveredAsync a deadline. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)
ethan-hann added this to the Code Cleanup milestone 2026-10-27 21:26:20 -05:00
Author
Owner

Shipped in SavePoint 0.9.22 (PR #274). Off-thread tests now cover the editor and library, and the Games, History and shell row-click tests run on the real dispatcher. No shell list changes inside its own selection setter (the setters only flip IsSelected; Rebuild runs from posted job events), so a list-changed-during-selection test there could not fail; Activity keeps its own.

Shipped in [SavePoint 0.9.22](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.22) (PR #274). Off-thread tests now cover the editor and library, and the Games, History and shell row-click tests run on the real dispatcher. No shell list changes inside its own selection setter (the setters only flip IsSelected; Rebuild runs from posted job events), so a list-changed-during-selection test there could not fail; Activity keeps its own.
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#260
No description provided.