Let ComposedApp take a dispatcher and cover the editor, shell and library off the UI thread #260
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#260
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
ComposedApp builds the app with the instant dispatcher and has no dispatcher parameter, and the dispatcher parameters on EditorRig, HistoryRig, SettingsRig and ShellViewHarness have no caller, so no off-thread test covers the editor, shell or library. Add the parameter, write #246-shaped tests (events delivered off the UI thread, a list changed during selection) for those screens, and make the off-thread tests able to tell a handler that posts from one that writes off the UI thread. Give FakeBackend.WhenEventsDeliveredAsync a deadline. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)
Shipped in SavePoint 0.9.22 (PR #274). Off-thread tests now cover the editor and library, and the Games, History and shell row-click tests run on the real dispatcher. No shell list changes inside its own selection setter (the setters only flip IsSelected; Rebuild runs from posted job events), so a list-changed-during-selection test there could not fail; Activity keeps its own.