Replace the EstimatesStoppedAtRunStart flag the Free up space fakes set for themselves #259

Closed
opened 2026-10-27 21:26:19 -05:00 by ethan-hann · 1 comment
Owner

FakeGamesApi and FakeSettingsApi set EstimatesStoppedAtRunStart themselves, and StorageSectionFreeUpTests and FreeUpSpaceViewModelTests assert it, so the tests check the fake's own bookkeeping. Replace it with a contract step that runs a real estimate and then a real Free up space run, and have the App tests assert what the player sees (the estimate cancelled, no late size line). (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)

FakeGamesApi and FakeSettingsApi set EstimatesStoppedAtRunStart themselves, and StorageSectionFreeUpTests and FreeUpSpaceViewModelTests assert it, so the tests check the fake's own bookkeeping. Replace it with a contract step that runs a real estimate and then a real Free up space run, and have the App tests assert what the player sees (the estimate cancelled, no late size line). (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)
ethan-hann added this to the Code Cleanup milestone 2026-10-27 21:26:19 -05:00
Author
Owner

Shipped in SavePoint 0.9.22 (PR #274).

Shipped in [SavePoint 0.9.22](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.22) (PR #274).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#259
No description provided.