Render checks that only assert a file exists or its size still run in the gate #257
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#257
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Render cases in ActivityScreenViewTests and StyleGalleryRenderTests, and the render calls in GamesProfileSearchViewTests, HistorySearchViewTests, ShellGameSearchViewTests, PinnedFooterTests, HelpAccessTests and RenderSettleTests still draw PNGs in every gate run and assert at most that the file exists or is over a size. Move the drawing behind SAVEPOINT_RENDER=1 (RenderOutput / ComposedApp.RenderIfRequested) and keep only assertions that can fail for a layout regression; RenderSettleTests keeps a render only if settling cannot be checked another way. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)
Shipped in SavePoint 0.9.22 (PR #274).