Render checks that only assert a file exists or its size still run in the gate #257

Closed
opened 2026-10-27 21:26:15 -05:00 by ethan-hann · 1 comment
Owner

Render cases in ActivityScreenViewTests and StyleGalleryRenderTests, and the render calls in GamesProfileSearchViewTests, HistorySearchViewTests, ShellGameSearchViewTests, PinnedFooterTests, HelpAccessTests and RenderSettleTests still draw PNGs in every gate run and assert at most that the file exists or is over a size. Move the drawing behind SAVEPOINT_RENDER=1 (RenderOutput / ComposedApp.RenderIfRequested) and keep only assertions that can fail for a layout regression; RenderSettleTests keeps a render only if settling cannot be checked another way. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)

Render cases in ActivityScreenViewTests and StyleGalleryRenderTests, and the render calls in GamesProfileSearchViewTests, HistorySearchViewTests, ShellGameSearchViewTests, PinnedFooterTests, HelpAccessTests and RenderSettleTests still draw PNGs in every gate run and assert at most that the file exists or is over a size. Move the drawing behind SAVEPOINT_RENDER=1 (RenderOutput / ComposedApp.RenderIfRequested) and keep only assertions that can fail for a layout regression; RenderSettleTests keeps a render only if settling cannot be checked another way. (standard: .agents/coding-standards/tests-meaningful-and-fast.md, Known violations)
ethan-hann added this to the Code Cleanup milestone 2026-10-27 21:26:15 -05:00
Author
Owner

Shipped in SavePoint 0.9.22 (PR #274).

Shipped in [SavePoint 0.9.22](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.22) (PR #274).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#257
No description provided.