Say a folder can't be checked right now, not that a stopped switch needs finishing, when the empty-start check hits a read failure #235
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#235
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
When the empty-start safety check (StartEmptyRule, D65) hits a generic git or IO failure while it reads a folder, the profile wizard's preview shows the stopped-switch reason ("Finish or discard the stopped switch first"), which is not what happened and gives the player the wrong fix. Give that case its own block and show the "can't check the files right now" reason (validation.profile.startEmptyUnchecked) instead. A corrupt HEAD makes the whole preview fail before reaching this code, so the test needs a failure injected at the read the check makes.
Fixed in 0.9.19 (PR 252): https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.19