Say a folder can't be checked right now, not that a stopped switch needs finishing, when the empty-start check hits a read failure #235

Closed
opened 2026-10-27 12:14:32 -05:00 by ethan-hann · 1 comment
Owner

When the empty-start safety check (StartEmptyRule, D65) hits a generic git or IO failure while it reads a folder, the profile wizard's preview shows the stopped-switch reason ("Finish or discard the stopped switch first"), which is not what happened and gives the player the wrong fix. Give that case its own block and show the "can't check the files right now" reason (validation.profile.startEmptyUnchecked) instead. A corrupt HEAD makes the whole preview fail before reaching this code, so the test needs a failure injected at the read the check makes.

When the empty-start safety check (StartEmptyRule, D65) hits a generic git or IO failure while it reads a folder, the profile wizard's preview shows the stopped-switch reason ("Finish or discard the stopped switch first"), which is not what happened and gives the player the wrong fix. Give that case its own block and show the "can't check the files right now" reason (validation.profile.startEmptyUnchecked) instead. A corrupt HEAD makes the whole preview fail before reaching this code, so the test needs a failure injected at the read the check makes.
ethan-hann added this to the Later milestone 2026-10-27 12:14:32 -05:00
Author
Owner
Fixed in 0.9.19 (PR 252): https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.19
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#235
No description provided.