Switching on Windows to a snapshot that already holds file links writes text files in their place #215
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#215
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Windows now refuses to snapshot or switch a folder that holds a file symlink (D62). A snapshot taken before that fix may already hold link entries (git mode 120000, the link's target path as content). Switching to such a snapshot on Windows still writes a plain text file holding the path where the link was, because core.symlinks is off, so a mod manager's link deployment in that profile stops loading. The refusal only looks at the folder on disk, not at the target snapshot.
Default proposed: before writing anything, the switch checks the target snapshot for link entries on Windows and refuses with copy that names the profile and the first file, says the profile was snapshotted while a mod manager linked its files, and suggests redeploying the mods in the mod manager after switching to another profile; Discard and the other profiles stay usable. Alternative, if Developer Mode or admin is available: recreate the links (core.symlinks=true for that checkout) when the link targets exist. Linux and macOS are not affected.
Shipped in 0.9.17 (PR 227).