Give the remaining fixed Task.Delay waits in tests a stated clock or a condition wait #214
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#214
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
.agents/coding-standards/tests-naming-and-structure.mdsays a test waits on a condition with a deadline and keeps a fixed delay only with a comment that names an outside clock. About 30Task.Delay(<milliseconds>, ...)waits in tests have neither: 1100 ms waits for git's whole-second file times (for example AmendTests, RemovedSnapshotRecordTests, BranchCopyTests), which need only a comment, and 150 to 750 ms absence waits (for example StorageGateTests, CaptureQueuedTests, ReclaimInterruptedTests), which should wait on a condition or say why a fixed absence window is right. Find them withgrep -rn --include=*.cs "Task.Delay(" tests, and widen the standard's verification grep to match.Shipped in 0.9.17 (PR 227).