Rename GitProcessRegistry's persist flag and give each registry its own note entry #213
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#213
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
GitProcessRegistry.Entry.Persist and the persist parameter mean "named in the running-git note", which reads as the opposite of GitRunner's SurvivesExit (a reclaim git that survives exit is added with persist: false). Rename it (for example Noted) so the two read the same way. Also, two registries on one runtime folder (tests restart a backend on the same folder) still overwrite each other's note while both run, because the note is one list per file; a close rewrites the survivor's gits, which hides it. Merge the writes or keep one entry per registry so neither drops the other's gits.
Shipped in 0.9.17 (PR 227).