Take a snapshot in the game header stays enabled while the row's snapshot runs #209

Closed
opened 2026-10-27 01:06:46 -05:00 by ethan-hann · 1 comment
Owner

GamesScreenViewModel's header Take a snapshot command gates on the loaded row's TakeSnapshotCommand.CanExecute, but nothing listens for that row's CanExecuteChanged; the header refreshes only through RefreshSnapshotHeader. While a snapshot started from the row's More actions menu is running, the header button can stay enabled, and ExecuteAsync does not check CanExecute, so a click starts a second run. Listen for the row command's CanExecuteChanged (or refresh the header when the row's busy state changes) and add a test that starts the row's snapshot and checks the header button is disabled until it ends.

GamesScreenViewModel's header Take a snapshot command gates on the loaded row's TakeSnapshotCommand.CanExecute, but nothing listens for that row's CanExecuteChanged; the header refreshes only through RefreshSnapshotHeader. While a snapshot started from the row's More actions menu is running, the header button can stay enabled, and ExecuteAsync does not check CanExecute, so a click starts a second run. Listen for the row command's CanExecuteChanged (or refresh the header when the row's busy state changes) and add a test that starts the row's snapshot and checks the header button is disabled until it ends.
ethan-hann added this to the 1.0 milestone 2026-10-27 01:06:46 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#209
No description provided.