Take a snapshot in the game header stays enabled while the row's snapshot runs #209
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#209
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
GamesScreenViewModel's header Take a snapshot command gates on the loaded row's TakeSnapshotCommand.CanExecute, but nothing listens for that row's CanExecuteChanged; the header refreshes only through RefreshSnapshotHeader. While a snapshot started from the row's More actions menu is running, the header button can stay enabled, and ExecuteAsync does not check CanExecute, so a click starts a second run. Listen for the row command's CanExecuteChanged (or refresh the header when the row's busy state changes) and add a test that starts the row's snapshot and checks the header button is disabled until it ends.
Shipped in 0.9.17 (PR 227).