Wait longer for a switch note another program holds before treating it as unreadable #196
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#196
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
SwitchJournal.Read and Clear try 4 times with waits of 30, 60 and 90 ms, so a switch note held by another program (an antivirus scan, a backup tool) is given up on after about 180 ms. Read then reports a stopped switch with no known target, which refuses snapshots and offers only Discard; Clear reports the note as stuck. Nothing is lost, but a slow scanner on a mid-range PC can push a player into Discard for no reason. Measure how long common scanners hold a freshly written small file and size the waits (one constant in SwitchJournal covers both) so a normal scan is outlasted.
Shipped in 0.9.17 (PR 227).