Take review names out of test comments #188

Closed
opened 2026-10-26 17:56:39 -05:00 by ethan-hann · 1 comment
Owner

.agents/coding-standards/csharp-comments.md says a comment never names a milestone, slice, issue, task, review, pull request, or build step.

  • tests/Savepoint.App.Tests/Theme/ThemePolishTests.cs: the header starts "Findings from the theme review". Say what the tests pin instead.
  • The render-test headers (GamesRenderTests, HistoryRenderTests, SettingsRenderTests, LaunchRenderTests, ShellRenderTests, GameEditorRenderTests, ArtworkRenderTests, HelpRenderTests, StyleGalleryRenderTests) say the PNGs are "for review". Say what a person compares them with instead.

The launch flow's review of a half-switched folder is a product screen and stays.

`.agents/coding-standards/csharp-comments.md` says a comment never names a milestone, slice, issue, task, review, pull request, or build step. - `tests/Savepoint.App.Tests/Theme/ThemePolishTests.cs`: the header starts "Findings from the theme review". Say what the tests pin instead. - The render-test headers (`GamesRenderTests`, `HistoryRenderTests`, `SettingsRenderTests`, `LaunchRenderTests`, `ShellRenderTests`, `GameEditorRenderTests`, `ArtworkRenderTests`, `HelpRenderTests`, `StyleGalleryRenderTests`) say the PNGs are "for review". Say what a person compares them with instead. The launch flow's review of a half-switched folder is a product screen and stays.
ethan-hann added this to the Code Cleanup milestone 2026-10-26 17:56:39 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#188
No description provided.