Skip StreamedPackFailureTests on Linux and macOS instead of returning early #187

Closed
opened 2026-10-26 17:56:38 -05:00 by ethan-hann · 1 comment
Owner

StreamedPackFailureTests.A_keep_that_cannot_be_removed_at_a_reclaim_is_a_reported_failure_not_a_raw_exception returns early when the OS is not Windows, so it passes on Linux without testing anything. .agents/coding-standards/csharp-platform-specific-code.md says such a test calls Assert.SkipUnless(OperatingSystem.IsWindows(), "...") and is listed in build/expected-skips/linux-ci.txt. Change it, add the list entry, and look for other early returns on an OS check in tests.

`StreamedPackFailureTests.A_keep_that_cannot_be_removed_at_a_reclaim_is_a_reported_failure_not_a_raw_exception` returns early when the OS is not Windows, so it passes on Linux without testing anything. `.agents/coding-standards/csharp-platform-specific-code.md` says such a test calls `Assert.SkipUnless(OperatingSystem.IsWindows(), "...")` and is listed in `build/expected-skips/linux-ci.txt`. Change it, add the list entry, and look for other early returns on an OS check in tests.
ethan-hann added this to the Code Cleanup milestone 2026-10-26 17:56:38 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#187
No description provided.