Stop App view models importing Savepoint.Core.Services.Storage #184
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#184
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
docs/architecture.mdand.agents/coding-standards/app-mvvm-view-models.mdsay the App calls Core only through the Api. Three view models importSavepoint.Core.Services.StorageforSnapshotFolderNames:ErrorCardViewModel,StorageSectionViewModel, andClearAllDataSectionViewModel.StorageSectionViewModelalso takes the internalSettingsStore.Move what the App needs (the folder-name formatting) onto the Api surface, and give
StorageSectionViewModelan Api for the settings it reads. Done whengrep -rnE --include=*.cs "using Savepoint\.Core\.(Services|Git|Paths)" src/Savepoint.Appprints nothing.Shipped in 0.9.17 (PR 227).