Stop App view models importing Savepoint.Core.Services.Storage #184

Closed
opened 2026-10-26 17:56:33 -05:00 by ethan-hann · 1 comment
Owner

docs/architecture.md and .agents/coding-standards/app-mvvm-view-models.md say the App calls Core only through the Api. Three view models import Savepoint.Core.Services.Storage for SnapshotFolderNames: ErrorCardViewModel, StorageSectionViewModel, and ClearAllDataSectionViewModel. StorageSectionViewModel also takes the internal SettingsStore.

Move what the App needs (the folder-name formatting) onto the Api surface, and give StorageSectionViewModel an Api for the settings it reads. Done when grep -rnE --include=*.cs "using Savepoint\.Core\.(Services|Git|Paths)" src/Savepoint.App prints nothing.

`docs/architecture.md` and `.agents/coding-standards/app-mvvm-view-models.md` say the App calls Core only through the Api. Three view models import `Savepoint.Core.Services.Storage` for `SnapshotFolderNames`: `ErrorCardViewModel`, `StorageSectionViewModel`, and `ClearAllDataSectionViewModel`. `StorageSectionViewModel` also takes the internal `SettingsStore`. Move what the App needs (the folder-name formatting) onto the Api surface, and give `StorageSectionViewModel` an Api for the settings it reads. Done when `grep -rnE --include=*.cs "using Savepoint\.Core\.(Services|Git|Paths)" src/Savepoint.App` prints nothing.
ethan-hann added this to the Code Cleanup milestone 2026-10-26 17:56:33 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#184
No description provided.