Give the Settings and History screens a Dependencies record #183

Closed
opened 2026-10-26 17:56:32 -05:00 by ethan-hann · 1 comment
Owner

.agents/coding-standards/app-mvvm-view-models.md says a screen factory gets only what the screen needs, in a <Screen>Dependencies record, and never keeps the whole FeatureContext. SettingsScreenFactory and HistoryScreenFactory both keep FeatureContext and read Services from it. Build a SettingsDependencies and a HistoryDependencies in FeatureComposition.Settings.cs and FeatureComposition.History.cs, as ActivityDependencies does.

`.agents/coding-standards/app-mvvm-view-models.md` says a screen factory gets only what the screen needs, in a `<Screen>Dependencies` record, and never keeps the whole `FeatureContext`. `SettingsScreenFactory` and `HistoryScreenFactory` both keep `FeatureContext` and read `Services` from it. Build a `SettingsDependencies` and a `HistoryDependencies` in `FeatureComposition.Settings.cs` and `FeatureComposition.History.cs`, as `ActivityDependencies` does.
ethan-hann added this to the Code Cleanup milestone 2026-10-26 17:56:32 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#183
No description provided.