Say why each static in GitProcessRegistry is static #181
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#181
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
.agents/coding-standards/core-injected-side-effects.mdallows a static for a process-lifetime OS resource and the record of what it holds (D59), on condition that a comment on each field says why it is static.GitProcessJob._jobhas that comment. Insrc/Savepoint.Core/Git/GitProcessRegistry.cs,_shared,_forApp, and_exitHookedhave none; only the class header explains the registry. Add a one-line reason to each field, or make a field an instance field if it has no process-lifetime reason.Shipped in 0.9.17 (PR 227).