Say why each static in GitProcessRegistry is static #181

Closed
opened 2026-10-26 17:56:29 -05:00 by ethan-hann · 1 comment
Owner

.agents/coding-standards/core-injected-side-effects.md allows a static for a process-lifetime OS resource and the record of what it holds (D59), on condition that a comment on each field says why it is static. GitProcessJob._job has that comment. In src/Savepoint.Core/Git/GitProcessRegistry.cs, _shared, _forApp, and _exitHooked have none; only the class header explains the registry. Add a one-line reason to each field, or make a field an instance field if it has no process-lifetime reason.

`.agents/coding-standards/core-injected-side-effects.md` allows a static for a process-lifetime OS resource and the record of what it holds (D59), on condition that a comment on each field says why it is static. `GitProcessJob._job` has that comment. In `src/Savepoint.Core/Git/GitProcessRegistry.cs`, `_shared`, `_forApp`, and `_exitHooked` have none; only the class header explains the registry. Add a one-line reason to each field, or make a field an instance field if it has no process-lifetime reason.
ethan-hann added this to the Code Cleanup milestone 2026-10-26 17:56:29 -05:00
Author
Owner

Shipped in 0.9.17 (PR 227).

Shipped in [0.9.17](https://git.tortal.tech/ethan-hann/SavePoint/releases/tag/v0.9.17) (PR 227).
Sign in to join this conversation.
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
ethan-hann/SavePoint#181
No description provided.