Take the cancellation token off four short Api mutations, or make them jobs #180
Labels
No labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
ethan-hann/SavePoint#180
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
.agents/coding-standards/core-api-results-and-errors.md(rule "Match the token to the kind of call") says a read takes aCancellationToken, a long job is cancelled throughIJobsApi.CancelAsync, and a short mutation takes no token. These mutations take one:IAppStatusApi.UseStorageFolderAsyncIAppStatusApi.RecoverCatalogFileAsyncIAppStatusApi.StartWithEmptyStorageAsyncIGamesApi.ExportDefinitionAsyncFor each, decide first: if it finishes quickly, drop the token. If it can run long enough that a player wants to stop it, make it a job that returns
JobStarted. Update the fake backend and the callers in the App with it.Shipped in 0.9.17 (PR 227).